-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand evidences
#1337
base: main
Are you sure you want to change the base?
Expand evidences
#1337
Conversation
@@ -72,6 +76,10 @@ | |||
"description": "Describes details about the DNS query associated to the activity that triggered the detection.", | |||
"requirement": "recommended" | |||
}, | |||
"resources": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should distinguish between this and the top level resources
array that we have in this class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming you mean to make it more specific to its description as a Cloud Resource.
If so, I suggest we override the caption within the object, so that resources
doesn't say Resource Details Array
which threw me at first: I thought it was details about some specific resource that was already present, which would have been ambiguous within the list of other resources.
If we override the caption to reflect what the intent is, Cloud Resources, or even Other Cloud Resources, we aren't detailing something specific but rather using the object for "other" resources in the cloud that we don't/can't have specific objects for.
Signed-off-by: Jonathan Rau <[email protected]>
Signed-off-by: Jonathan Rau <[email protected]>
Very minor - since you are adding |
Related Issue:
Description of changes:
resource_details
toevidences
. This allows producers/mappers to account for cloud-based resources and other generic resources that does not fit well withindevice
ornetwork_endpoint
. For instance, theamazonResourceEvidence
evidence type in the Microsoft Graph Security List Alerts V2 API.name
toevidences
. In various upstream platforms such as Microsoft Graph and CrowdStrike, there are either naming conventions for the type of evidence (e.g.,amazonResourceEvidence
) or an actual display name or direct name such as thedisplay_name
value within Behaviors associated with Incidents in CrowdStrike Falcon. Microsoft Defender also has an array ofevidence
associated with their alerts that each contain theentityType
key which identities the name of the evidence.uid
toevidences
much for the same reason asname
. Platforms often have a GUID of some sort identifying the specific evidence associated with an alert such asactivity_id
associated with Crowdstrike Falcon Alerts which is the smallest "unit" of alerting/detection data. Likewise, the Behaviors associated with CrowdStrike Falcon Incidents each have their ownbehavior_id
which ties them to the Incident ID itself.verdict
andverdict_id
toevidences
to normalize similar values in other systems. In every single Evidence type within Microsoft Graph Security Alerts, there is averdict
enumeration. Likewise, Microsoft Defender for Graph Alerts haveevidence
arrays with each one containing aDetectionStatus
to denotes if something was a FP, TP, or otherwise.