Implement more Unix primitives #1829
Open
+1,305
−142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hhugo
reviewed
Feb 4, 2025
|
Aren't there any test in the ocaml testsuite for theses ? |
vouillon
force-pushed
the
unix
branch
2 times, most recently
from
59aac2f to
b80e20e
Compare
Many of them are not tested. I have added a test but it is far from complete. I'll write more. |
vouillon
force-pushed
the
unix
branch
16 times, most recently
from
341aefd to
248117f
Compare
|
@hhugo I have added some tests |
vouillon
force-pushed
the
unix
branch
4 times, most recently
from
96b17f1 to
d79de32
Compare
hhugo
reviewed
Feb 25, 2025
| if (!src_root.device.link) { | ||
| caml_failwith("caml_unix_link: not implemented"); | ||
| } | ||
| if (typeof follow !== "number") |
There was a problem hiding this comment.
Can you add a comment explain this ?
hhugo
reviewed
Feb 25, 2025
| //Provides: caml_unix_geteuid | ||
| //Alias: unix_geteuid | ||
| function caml_unix_geteuid(unit) { | ||
| if (globalThis.process && globalThis.process.geteuid) { |
hhugo
reviewed
Feb 25, 2025
| @@ -605,6 +617,17 @@ | |||
| (struct.get $channel $fd (local.get $ch)))) | |||
| (i64.extend_i32_s (struct.get $channel $curr (local.get $ch)))))) | |||
|
|
|||
| (;ZZZ | |||
hhugo
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.