Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX]: reworks all number parameter names to represent what they actually are. Refactors some types to be the appropriate types based on OpenAPI and docs. #2948

Merged
merged 3 commits into from
Jul 2, 2024

Conversation

nickfloyd
Copy link
Contributor

@nickfloyd nickfloyd commented Jul 2, 2024

Resolves #2893


Before the change?

  • The parameter names for numbers are not descriptive and do not represent what they actually are.
  • The types defined in the constructors of some resources were not the appropriate types based on OpenAPI and docs.
  • ApplicationAuthorization
  • Organization
  • User
  • PullRequestReviewComment.InReplyToId and PullRequestReviewComment.PullRequestReviewId types were incorrectly defined. They should be long, not int32.

After the change?

  • All number parameter names have been reworked to represent what they actually are.
  • ApplicationAuthorization
  • Organization
  • User
  • PullRequestReviewComment.InReplyToId and PullRequestReviewComment.PullRequestReviewId types have been corrected to long.

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

@nickfloyd nickfloyd marked this pull request as ready for review July 2, 2024 18:32
Copy link
Member

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work chasing this down! ❤️

@nickfloyd nickfloyd merged commit 6bb0408 into main Jul 2, 2024
5 checks passed
@nickfloyd nickfloyd deleted the rework-int-types branch July 2, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG]: Int32 overflow for Github object ids
2 participants