Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor out attributes into EventAttributes class #721

Merged
merged 26 commits into from
Feb 27, 2025

Conversation

cortadocodes
Copy link
Member

@cortadocodes cortadocodes commented Feb 11, 2025

Contents (#721)

Enhancements

  • Remove need to (de)serialise None attribute values

Refactoring

  • Factor out event attributes into EventAttributes class

Operations

  • Revert change to workload identity provider for test runner

Other

  • Disable question cancellation methods for now

@cortadocodes cortadocodes self-assigned this Feb 11, 2025
Base automatically changed from add-kueue-service-backend to rc-kueue February 17, 2025 10:31
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 97.72727% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (rc-kueue@fd6289d). Learn more about missing BASE report.

Files with missing lines Patch % Lines
octue/cloud/pub_sub/service.py 93.93% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             rc-kueue     #721   +/-   ##
===========================================
  Coverage            ?   93.69%           
===========================================
  Files               ?       85           
  Lines               ?     3682           
  Branches            ?        0           
===========================================
  Hits                ?     3450           
  Misses              ?      232           
  Partials            ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cortadocodes cortadocodes merged commit 4df4719 into rc-kueue Feb 27, 2025
5 checks passed
@cortadocodes cortadocodes deleted the factor-out-event-attributes branch February 27, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants