Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PERF] compiler: build literal value objects once #4901

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

LucasLefevre
Copy link
Collaborator

With this commit, literal value objects like
{ value: this.constantValues.numbers[0] } are built only once, at compile time, instead of being created (and garbage collected) at every evaluation

before: coming soon
after: coming soon

Task: 4134564

Description:

description of this task, what is implemented and why it is implemented that way.

Task: TASK_ID

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

With this commit, literal value objects like
`{ value: this.constantValues.numbers[0] }` are built only once, at compile
time, instead of being created (and garbage collected) at every evaluation

before: coming soon
after: coming soon

Task: 4134564
@robodoo
Copy link
Collaborator

robodoo commented Aug 23, 2024

Pull request status dashboard

A constant is a variable whose value can't be modified.
Literals is a raw value that is expressed by itself.

25 or "Hello" are both literals.

Task: 4134564
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants