[FIX] pivot: add suggestion message to broken pivot formulas #4956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
LucasLefevre
force-pushed
the
saas-17.4-broken-pivot-suggestion-lul
branch
from
b333199
to
a967497
Compare
hokolomopo
reviewed
Sep 16, 2024
src/components/side_panel/pivot/pivot_defer_update/pivot_defer_update.xml
Outdated
Show resolved
Hide resolved
src/components/side_panel/pivot/pivot_defer_update/pivot_defer_update.xml
Outdated
Show resolved
Hide resolved
LucasLefevre
force-pushed
the
saas-17.4-broken-pivot-suggestion-lul
branch
from
a967497
to
75fff9d
Compare
|
oups, forgot to push the latest version 😅 |
Since the pivot insertion is inserting static formulas, if the user changes the groups, the static formulas are no longer correct and are in error. The user might not understand what's happening and how to fix the issue. This commit adds more info to the formula error message to help the user. And a notification when updating the pivot if no dynamic pivot is visible to the user. Technical note: instead of changing the existing message, I added a second one, which I concatenate to the existing one. The reason is to avoid breaking existing translations in a stable version. Task: 4169586
LucasLefevre
force-pushed
the
saas-17.4-broken-pivot-suggestion-lul
branch
from
75fff9d
to
714ed0b
Compare
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Since the pivot insertion is inserting static formulas, if the user changes the groups, the static formulas are no longer correct and are in error. The user might not understand what's happening and how to fix the issue.
This commit adds more info to the error message to help the user.
A similar issue happens with measures: when adding a new measure, nothing happens in the grid => no feedback.
Technical note: instead of changing the existing message, I added a second one, which I concatenate to the existing one. The reason is to avoid breaking existing translations in a stable version.
Task: 4169586
review checklist