[IMP] custom color: handle all the chart colors #4967
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rrahir
reviewed
Sep 13, 2024
rrahir
reviewed
Sep 13, 2024
hokolomopo
force-pushed
the
master-chart-custom-color-adrm
branch
from
4febd0d
to
9c10c0c
Compare
|
@robodoo r+ |
|
@robodoo r- |
Because it's way better performance-wise to not parse the chart every time we have some random command that triggers a finalize, but to only do that when we have a command that actually updates the chart. Actually I think I'll do another commit to compute every color this way, the plugin does not care at all about the evaluation, so it make no sense to do things in the finalize ? (I guess there was some older version of this plugin where it mattered). And handling the commands separatly would be way better than looping on every cell at each command. |
The custom color plugin wasn't handling data series color, or chart title color. Now we run a regex through the whole chart definition to get all the colors, so we don't have to think to add new handling in the custom color plugin every time we add a chart customization. Task: 4178763
hokolomopo
force-pushed
the
master-chart-custom-color-adrm
branch
from
9c10c0c
to
fa19ac1
Compare
robodoo
pushed a commit
that referenced
this pull request
Sep 20, 2024
The custom color plugin wasn't handling data series color, or chart title color. Now we run a regex through the whole chart definition to get all the colors, so we don't have to think to add new handling in the custom color plugin every time we add a chart customization. closes #4967 Task: 4178763 Signed-off-by: Lucas Lefèvre (lul) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The custom color plugin wasn't handling data series color, or chart title color. Now we run a regex through the whole chart definition to get all the colors, so we don't have to think to add new handling in the custom color plugin every time we add a chart customization.
Task: 4178763
review checklist