[FIX] composer: auto-complete pivot dimension after operator #4972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Steps to reproduce: - insert a pivot - add a calculated measure (the default formula is "=0") - delete the "0" => the auto-complete isn't displayed The "=" is used as the search term to filter the dimensions (but no dimension matches) Task: 4176433
LucasLefevre
force-pushed
the
master-auto-complete-after-operator-lul
branch
from
8a84730
to
40b8f89
Compare
|
robodoo rebase-ff |
|
Merge method set to rebase and fast-forward. |
LucasLefevre
force-pushed
the
master-auto-complete-after-operator-lul
branch
from
40b8f89
to
1545a04
Compare
The auto-complete of pivot dimension shows up on too many situations It should only show up when the cursor is somewhere where a range is expected or when it's on a symbol (which acts as a search term) A notable exception is for boolean values where the auto-complete should be hidden if the cursor is at true or false Task: 4176433
Steps to reproduce: - type in a formula =SU - close the aut-completes with the cross at the top right corner - hit Enter => the formula is completed to =SUM( Task: 4176433
LucasLefevre
force-pushed
the
master-auto-complete-after-operator-lul
branch
from
1545a04
to
52a4f41
Compare
|
robodoo rebase-ff r+ |
|
Merge method set to rebase and fast-forward. |
robodoo
pushed a commit
that referenced
this pull request
Sep 24, 2024
Steps to reproduce: - insert a pivot - add a calculated measure (the default formula is "=0") - delete the "0" => the auto-complete isn't displayed The "=" is used as the search term to filter the dimensions (but no dimension matches) Task: 4176433 Part-of: #4972 Signed-off-by: Pierre Rousseau (pro) <[email protected]>
robodoo
pushed a commit
that referenced
this pull request
Sep 24, 2024
The auto-complete of pivot dimension shows up on too many situations It should only show up when the cursor is somewhere where a range is expected or when it's on a symbol (which acts as a search term) A notable exception is for boolean values where the auto-complete should be hidden if the cursor is at true or false Task: 4176433 Part-of: #4972 Signed-off-by: Pierre Rousseau (pro) <[email protected]>
robodoo
pushed a commit
that referenced
this pull request
Sep 24, 2024
Steps to reproduce: - type in a formula =SU - close the aut-completes with the cross at the top right corner - hit Enter => the formula is completed to =SUM( closes #4972 Task: 4176433 Signed-off-by: Pierre Rousseau (pro) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Steps to reproduce:
=> the auto-complete isn't displayed
Task: 4176433
review checklist