[FIX] runbot: warn when a local pg backend cannot be terminated #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For whatever reason, it happens that we open a testing database in a psql console as another user. In that case, the runbot is unable to terminate the backend and goes in an error loop.
Xavier-Do
requested changes
Feb 9, 2023
| try: | ||
| query = 'SELECT pg_terminate_backend({}) FROM pg_stat_activity WHERE datname=%s'.format(pid_col) | ||
| except InsufficientPrivilege: | ||
| _logger.warning('Cannot terminate backend process for %s (maybe a root psql console is accessing the database).', dbname) |
There was a problem hiding this comment.
We could maybe add a runbot warning? this could be like that for a while.
I'm also worried because it could wait for a while an slow down the loop. Not sure
We could add a mechanism like pull_info_failures to avoid spamming the log and avoid useless retry. Just keeping a list of failed database in memory maybe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For whatever reason, it happens that we open a testing database in a psql console as another user. In that case, the runbot is unable to terminate the backend and goes in an error loop.