Correctly consider XML instruct declaration encoding when creating Hash using Ox.load(xml, mode: :hash) #350
+71
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sh using Ox.load(xml, mode: :hash)
Uelb
changed the title
ohler55
approved these changes
Mar 21, 2024
|
Nicely done. Thanks you. |
|
Looks like some errors in CI. Can you look at the formatting errors before I merge? |
Uelb
force-pushed
the
fix-hash-mode-encoding-consideration
branch
from
01a03fd to
773d474
Compare
|
@ohler55 I ran clang-format and rubocop fix on all the necessary files so it should be ok now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix #344
I replicated the behavior of gen_load when it comes to determining which encoding to associate when dealing with elements.