Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(agent): Fixed json validation in slurm job data #722

Merged
merged 2 commits into from
Feb 13, 2025

Conversation

dusktreader
Copy link
Contributor

Slurm started returning the slurm job state as a list in Slurm 23.11.
In order to support this and older versions of Slurm, the pydantic
schema was updated to handle both.

Slurm started returning the slurm job state as a list in Slurm 23.11.
In order to support this and older versions of Slurm, the pydantic
schema was updated to handle both.
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.93%. Comparing base (0eb872f) to head (26a8da3).
Report is 1 commits behind head on release/5.5.

Additional details and impacted files
@@               Coverage Diff               @@
##           release/5.5     #722      +/-   ##
===============================================
- Coverage        92.93%   92.93%   -0.01%     
===============================================
  Files               88       88              
  Lines             4842     4852      +10     
===============================================
+ Hits              4500     4509       +9     
- Misses             342      343       +1     
Flag Coverage Δ
agent 93.98% <ø> (-0.06%) ⬇️
api 95.43% <ø> (ø)
cli 88.62% <ø> (ø)
core 96.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jamesbeedy jamesbeedy self-assigned this Feb 13, 2025
Copy link
Contributor

@jamesbeedy jamesbeedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@dusktreader dusktreader merged commit 099c2a4 into release/5.5 Feb 13, 2025
13 checks passed
@fschuch fschuch deleted the task/fix-json-validation-error branch March 17, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants