Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove dialect type from alembic migration #724

Merged

Conversation

jonathanlmatos
Copy link
Contributor

Vantage API runs the migrations during the organization creation process. Due to an incompatibility between versions 1.4 and 2.0 of SQLalchmey used by vantage api, it was needed to remove the Dialect type from alembic migration.

Vantage API runs the migrations during the organization creation process.
Due to an incompatibility between versions 1.4 and 2.0 of SQLalchmey used
by vantage api, it was needed to remove the Dialect type from alembic migration.
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.93%. Comparing base (3d55c7c) to head (d31dc05).
Report is 1 commits behind head on release/5.5.

Additional details and impacted files
@@             Coverage Diff              @@
##           release/5.5     #724   +/-   ##
============================================
  Coverage        92.93%   92.93%           
============================================
  Files               88       88           
  Lines             4852     4852           
============================================
  Hits              4509     4509           
  Misses             343      343           
Flag Coverage Δ
agent 93.98% <ø> (ø)
api 95.43% <ø> (ø)
cli 88.62% <ø> (ø)
core 96.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonathanlmatos jonathanlmatos merged commit 8e957d5 into release/5.5 Feb 13, 2025
13 checks passed
dusktreader pushed a commit that referenced this pull request Feb 13, 2025
Vantage API runs the migrations during the organization creation process.
Due to an incompatibility between versions 1.4 and 2.0 of SQLalchmey used
by vantage api, it was needed to remove the Dialect type from alembic migration.

Original Commit: d31dc05
dusktreader pushed a commit that referenced this pull request Feb 14, 2025
Vantage API runs the migrations during the organization creation process.
Due to an incompatibility between versions 1.4 and 2.0 of SQLalchmey used
by vantage api, it was needed to remove the Dialect type from alembic migration.

Original Commit: d31dc05
@fschuch fschuch deleted the fix/remove-dialect-type-from-alembic-migration branch March 17, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants