Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-pick(jobbergate-api): Removed the sa.Dialect type from alembic migration #727

Merged

Conversation

jonathanlmatos
Copy link
Contributor

Vantage API runs the migrations during the organization creation process. Due to an incompatibility between versions 1.4 and 2.0 of SQLalchmey used by vantage api, it was needed to remove the Dialect type from alembic migration.

… migration

Vantage API runs the migrations during the organization creation process.
Due to an incompatibility between versions 1.4 and 2.0 of SQLalchmey used
by vantage api, it was needed to remove the Dialect type from alembic migration.
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.93%. Comparing base (3d461c8) to head (6e393b6).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #727   +/-   ##
=======================================
  Coverage   92.93%   92.93%           
=======================================
  Files          88       88           
  Lines        4842     4842           
=======================================
  Hits         4500     4500           
  Misses        342      342           
Flag Coverage Δ
agent 94.04% <ø> (ø)
api 95.43% <ø> (ø)
cli 88.62% <ø> (ø)
core 96.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@fschuch fschuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Please, ensure it was covered on main, release/5.5, and release/5.4.

@fschuch
Copy link
Member

fschuch commented Feb 14, 2025

Notice this is duplicated with #726, so we can probably close this one.

@matheushent
Copy link
Member

Approved. Please, ensure it was covered on main, release/5.5, and release/5.4.

I think this is only relevant to main and release/5.5 (which the original commit comes from).

@jonathanlmatos jonathanlmatos merged commit a4839cb into main Feb 14, 2025
13 checks passed
@jonathanlmatos jonathanlmatos deleted the cherry-pick/remove-dialect-type-from-alembic-migration branch February 14, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants