cherry-pick(jobbergate-api): Removed the sa.Dialect type from alembic migration #727
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… migration Vantage API runs the migrations during the organization creation process. Due to an incompatibility between versions 1.4 and 2.0 of SQLalchmey used by vantage api, it was needed to remove the Dialect type from alembic migration.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #727 +/- ##
=======================================
Coverage 92.93% 92.93%
=======================================
Files 88 88
Lines 4842 4842
=======================================
Hits 4500 4500
Misses 342 342
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fschuch
approved these changes
Feb 14, 2025
|
Notice this is duplicated with #726, so we can probably close this one. |
I think this is only relevant to |
jonathanlmatos
deleted the
cherry-pick/remove-dialect-type-from-alembic-migration
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vantage API runs the migrations during the organization creation process. Due to an incompatibility between versions 1.4 and 2.0 of SQLalchmey used by vantage api, it was needed to remove the Dialect type from alembic migration.