Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/5.4] fix(agent): solve permission denied when asserting submit dir exist #730

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

github-actions[bot]
Copy link
Contributor

Backport 5f6beb7 from #713.

…713)

The previous approach with submit_dir.exists() runs as the agent user, which may face permission errors on the directory (like /home/fschuch). It is now verified as the submitter user.

(cherry picked from commit 5f6beb7)
@fschuch fschuch force-pushed the backport-713-to-release/5.4 branch from c0888ab to 07c1d19 Compare February 14, 2025 11:33
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.73%. Comparing base (dab8c11) to head (07c1d19).
Report is 1 commits behind head on release/5.4.

Additional details and impacted files
@@               Coverage Diff               @@
##           release/5.4     #730      +/-   ##
===============================================
+ Coverage        92.65%   92.73%   +0.07%     
===============================================
  Files               85       85              
  Lines             4466     4473       +7     
===============================================
+ Hits              4138     4148      +10     
+ Misses             328      325       -3     
Flag Coverage Δ
agent 94.00% <ø> (+0.61%) ⬆️
api 95.33% <ø> (ø)
cli 88.62% <ø> (ø)
core 96.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fschuch fschuch merged commit dd3de44 into release/5.4 Feb 17, 2025
13 checks passed
@fschuch fschuch deleted the backport-713-to-release/5.4 branch February 17, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants