Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(snap,agent,ci): Minor quality-of-life updates #733

Conversation

dusktreader
Copy link
Contributor

  • Added help text for some Makefile items that were missing them
  • Improved clean target for snap Makefile
  • Updated the CI to use default snap name

- Added help text for some Makefile items that were missing them
- Improved clean target for snap Makefile
- Updated the CI to use default snap name
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.93%. Comparing base (514229f) to head (ccdd343).

Additional details and impacted files
@@                          Coverage Diff                          @@
##           task/cherry-pick-from-release-5.5     #733      +/-   ##
=====================================================================
- Coverage                              93.00%   92.93%   -0.08%     
=====================================================================
  Files                                     88       88              
  Lines                                   4859     4852       -7     
=====================================================================
- Hits                                    4519     4509      -10     
- Misses                                   340      343       +3     
Flag Coverage Δ
agent 93.98% <ø> (-0.47%) ⬇️
api 95.43% <ø> (ø)
cli 88.62% <ø> (ø)
core 96.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment on lines -20 to +21
@git rev-parse --short HEAD > sha/commit-sha.txt
@snapcraft $(ARGS)
build: clean ## Build the snap
@snapcraft -v
mv *.snap jobbergate-agent.snap
Copy link
Contributor

@zsinx6 zsinx6 Feb 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain this part? The mv is to be used by the release, but the other change I did not follow

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure!

I made it dependent on clean so that the build environment would be fresh and any leftover .snap artifacts would be removed.

The command snapcraft -v builds the snap using verbose mode. (I can't imagine not wanting to see the output because if something goes wrong, you have to run it again in verbose mode anyway. Additionally, the CI was already using verbose mode. Just seemed like the right move.

@fschuch fschuch deleted the branch task/cherry-pick-from-release-5.5 March 17, 2025 12:40
@fschuch fschuch closed this Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants