chore(snap,agent,ci): Minor quality-of-life updates #733
Conversation
dusktreader
commented
Feb 14, 2025
dusktreader
commented
- Added help text for some Makefile items that were missing them
- Improved clean target for snap Makefile
- Updated the CI to use default snap name
- Added help text for some Makefile items that were missing them - Improved clean target for snap Makefile - Updated the CI to use default snap name
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## task/cherry-pick-from-release-5.5 #733 +/- ##
=====================================================================
- Coverage 93.00% 92.93% -0.08%
=====================================================================
Files 88 88
Lines 4859 4852 -7
=====================================================================
- Hits 4519 4509 -10
- Misses 340 343 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| @git rev-parse --short HEAD > sha/commit-sha.txt | ||
| @snapcraft $(ARGS) | ||
| build: clean ## Build the snap | ||
| @snapcraft -v | ||
| mv *.snap jobbergate-agent.snap |
There was a problem hiding this comment.
Can you explain this part? The mv is to be used by the release, but the other change I did not follow
There was a problem hiding this comment.
Sure!
I made it dependent on clean so that the build environment would be fresh and any leftover .snap artifacts would be removed.
The command snapcraft -v builds the snap using verbose mode. (I can't imagine not wanting to see the output because if something goes wrong, you have to run it again in verbose mode anyway. Additionally, the CI was already using verbose mode. Just seemed like the right move.
