fix(agent): update the validate_job_state validator to support data_parser 0.0.40
#739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_parser 0.0.40 This commit modifies the validator function `validate_job_state` from the `SlurmJobData` model in order to support the data_parser 0.0.40. Essentialy, in Slurm 24.11, the `--json` flag from the `scontrol show job` command uses the data_parser 0.0.40. According to the official [documentation](https://slurm.schedmd.com/job_state_codes.html#overview), the job flags can be returned alongside the job state, which can make the `job_state` key to have multiple keys.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/5.5 #739 +/- ##
============================================
Coverage 93.00% 93.00%
============================================
Files 88 88
Lines 4859 4859
============================================
Hits 4519 4519
Misses 340 340
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fschuch
requested changes
Mar 7, 2025
check 235c9ff please. |
fschuch
approved these changes
Mar 7, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Mar 7, 2025
…_parser 0.0.40 (#739) This commit modifies the validator function `validate_job_state` from the `SlurmJobData` model in order to support the data_parser 0.0.40. Essentialy, in Slurm 24.11, the `--json` flag from the `scontrol show job` command uses the data_parser 0.0.40. According to the official [documentation](https://slurm.schedmd.com/job_state_codes.html#overview), the job flags can be returned alongside the job state, which can make the `job_state` key to have multiple keys. (cherry picked from commit 1d97b8c)
matheushent
added a commit
that referenced
this pull request
Mar 7, 2025
…_parser 0.0.40 (#739) (#742) This commit modifies the validator function `validate_job_state` from the `SlurmJobData` model in order to support the data_parser 0.0.40. Essentialy, in Slurm 24.11, the `--json` flag from the `scontrol show job` command uses the data_parser 0.0.40. According to the official [documentation](https://slurm.schedmd.com/job_state_codes.html#overview), the job flags can be returned alongside the job state, which can make the `job_state` key to have multiple keys. (cherry picked from commit 1d97b8c) Co-authored-by: Matheus Tosta <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the validator function
validate_job_statefrom theSlurmJobDatamodel in order to support the data_parser 0.0.40.Essentialy, in Slurm 24.11, the
--jsonflag from thescontrol show jobcommand uses the data_parser 0.0.40. According to the official documentation, the job flags can be returned alongside the job state, which can make thejob_statekey to have multiple keys.