Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(agent): prevent int64 overflow from values fecthed from InfluxDB. #740

Merged
merged 1 commit into from
Mar 7, 2025

Conversation

matheushent
Copy link
Member

This commit modifies the fetch_influx_data function to return 0 in the measurement value and the original value is bigger than 2^63 - 1. This prevents an error in the API where the value is bigger than int64, causing the metrics to not be stored in the database.

This commit modifies the `fetch_influx_data` function to return 0 in the measurement
value and the original value is bigger than 2^63 - 1. This prevents an error in the API
where the value is bigger than int64, causing the metrics to not be stored in the database.
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.00%. Comparing base (6da5042) to head (e34e61f).
Report is 1 commits behind head on release/5.5.

Additional details and impacted files
@@             Coverage Diff              @@
##           release/5.5     #740   +/-   ##
============================================
  Coverage        93.00%   93.00%           
============================================
  Files               88       88           
  Lines             4859     4859           
============================================
  Hits              4519     4519           
  Misses             340      340           
Flag Coverage Δ
agent 94.45% <ø> (ø)
api 95.43% <ø> (ø)
cli 88.62% <ø> (ø)
core 96.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@matheushent matheushent merged commit a921df5 into release/5.5 Mar 7, 2025
14 checks passed
@matheushent matheushent deleted the task/fix-slurm-job-metrics-overflow branch March 7, 2025 19:19
github-actions bot pushed a commit that referenced this pull request Mar 7, 2025
…#740)

This commit modifies the `fetch_influx_data` function to return 0 in the measurement
value and the original value is bigger than 2^63 - 1. This prevents an error in the API
where the value is bigger than int64, causing the metrics to not be stored in the database.

(cherry picked from commit a921df5)
matheushent added a commit that referenced this pull request Mar 7, 2025
…#740) (#741)

This commit modifies the `fetch_influx_data` function to return 0 in the measurement
value and the original value is bigger than 2^63 - 1. This prevents an error in the API
where the value is bigger than int64, causing the metrics to not be stored in the database.

(cherry picked from commit a921df5)

Co-authored-by: Matheus Tosta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants