Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove libonedal_sycl.a from makefile #2970

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

fix: remove libonedal_sycl.a from makefile #2970

wants to merge 22 commits into from

Conversation

Alexandr-Solovev
Copy link
Contributor

@Alexandr-Solovev Alexandr-Solovev commented Nov 6, 2024 •
edited
Loading

Description

PR introduces removing libonedal_sycl.a library from oneDAL build. Originally it was a copy of libmkl_sycl.a library, but since oneMKL migration we observed an issue with increasing build size. With the current changes MKL_SYCL dependency will be added in static applications through CMake.

Checklist to comply with before moving PR from draft:

PR completeness and readability

  • I have reviewed my changes thoroughly before submitting this pull request.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with update and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have added a respective label(s) to PR if I have a permission for that.
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.
  • I have extended testing suite if new functionality was introduced in this PR.

@Alexandr-Solovev
Copy link
Contributor Author

/intelci: run

@Alexandr-Solovev
Copy link
Contributor Author

/intelci: run

@Alexandr-Solovev
Copy link
Contributor Author

/intelci: run

@Alexandr-Solovev
Copy link
Contributor Author

/intelci: run

@Alexandr-Solovev
Copy link
Contributor Author

/intelci: run

@Alexandr-Solovev Alexandr-Solovev added the dependencies Pull requests that update a dependency file label Nov 7, 2024
@Alexandr-Solovev
Copy link
Contributor Author

/intelci: run

@Alexandr-Solovev
Copy link
Contributor Author

/intelci: run

@Alexandr-Solovev
Copy link
Contributor Author

/intelci: run

@Alexandr-Solovev
Copy link
Contributor Author

/intelci: run

@Alexandr-Solovev
Copy link
Contributor Author

/intelci: run

@Alexandr-Solovev
Copy link
Contributor Author

/intelci: run

@Alexandr-Solovev Alexandr-Solovev marked this pull request as ready for review November 12, 2024 08:12
@Alexandr-Solovev
Copy link
Contributor Author

/intelci: run

@Alexandr-Solovev
Copy link
Contributor Author

/intelci: run

@Alexandr-Solovev
Copy link
Contributor Author

/intelci: run

@Alexandr-Solovev
Copy link
Contributor Author

/intelci: run

@Alexandr-Solovev
Copy link
Contributor Author

/intelci: run

@Alexandr-Solovev
Copy link
Contributor Author

Nightly: http://intel-ci.intel.com/efa1bd24-e590-f155-81b8-a4bf010d0e2d

Vika-F
Vika-F approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@Vika-F Vika-F left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for a semi-green CI and merge.

@Alexandr-Solovev
Copy link
Contributor Author

/intelci: run

@Alexandr-Solovev
Copy link
Contributor Author

Latest commit nightly: http://intel-ci.intel.com/efa1be5f-0cb1-f11c-b33b-a4bf010d0e2d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alexsandruss Alexsandruss Alexsandruss left review comments

@Vika-F Vika-F Vika-F approved these changes

@napetrov napetrov Awaiting requested review from napetrov napetrov is a code owner

@homksei homksei Awaiting requested review from homksei homksei is a code owner

@ahuber21 ahuber21 Awaiting requested review from ahuber21 ahuber21 is a code owner

@ethanglaser ethanglaser Awaiting requested review from ethanglaser ethanglaser is a code owner

@maria-Petrova maria-Petrova Awaiting requested review from maria-Petrova maria-Petrova is a code owner

@emmwalsh emmwalsh Awaiting requested review from emmwalsh emmwalsh is a code owner

@david-cortes-intel david-cortes-intel Awaiting requested review from david-cortes-intel

@icfaust icfaust Awaiting requested review from icfaust

@olegkkruglov olegkkruglov Awaiting requested review from olegkkruglov

@avolkov-intel avolkov-intel Awaiting requested review from avolkov-intel

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Alexandr-Solovev @Vika-F @Alexsandruss