Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enablement of bf16 jit:uni reorders for aarch64 #2104

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Re-enablement of bf16 jit:uni reorders for aarch64 #2104

merged 1 commit into from
Sep 30, 2024

Conversation

Shreyas-fuj
Copy link
Contributor

Description

The PR: #1986 changed a particular condition for bf_16(This was not intended in the PR). So after this was merged some testcases which were going to jin:uni before, started going to simple:any(reference). Therefore, this PR contains the fix for that by just reverting the un-intended change to the original.

Checklist

General

  • [y] Do all unit and benchdnn tests (make test and make test_benchdnn_*) pass locally for each commit?
make test

99% tests passed, 2 tests failed out of 200

Total Test time (real) = 2142.22 sec

The following tests FAILED:
	159 - test_graph_unit_dnnl_large_partition_usm_cpu (Failed)
	181 - test_benchdnn_modeC_graph_ci_cpu (Failed)
Errors while running CTest
Output from these tests are in: /home/shreyas/G/shr-fuj/oneDNN_open_source/build/Testing/Temporary/LastTest.log
Use "--rerun-failed --output-on-failure" to re-run the failed cases verbosely.
make: *** [Makefile:71: test] Error 8
  • [y] Have you formatted the code using clang-format?

@Shreyas-fuj Shreyas-fuj requested review from a team as code owners September 20, 2024 08:01
theComputeKid
theComputeKid requested changes Sep 20, 2024
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
@mgouicem
Copy link
Contributor

Could you please use commit messages the are aligned with the contributing guideline.
For example something like aarch64: reenable bf16 jit reorders

@theComputeKid
Copy link
Contributor

@Radu2k could you please review this for the aarch64 team? Thanks.

@Radu2k
Copy link
Contributor

Radu2k commented Sep 23, 2024

Could you please use commit messages the are aligned with the contributing guideline. For example something like aarch64: reenable bf16 jit reorders

I agree with Mourad on this topic and want to highly endorse the importance of PR message format as this will help speeding up the review process. By taking the time to correctly label the PR, we can easily identify and asses issues based on their commit message labels, therefore reviewing and closing your PRs sooner.
Here is the contribution guidance for your convenience: https://github.com/oneapi-src/oneDNN/blob/main/CONTRIBUTING.md#code-contribution-guidelines

Radu2k
Radu2k requested changes Sep 23, 2024
View reviewed changes
src/cpu/aarch64/jit_uni_reorder.cpp
@@ -1285,17 +1291,17 @@ struct jit_uni_reorder_kernel_f32_t : public kernel_t, public jit_generator {
}
}

bool interim_f32_needed() {
static bool interim_f32_needed(const prb_t &prb, bool compensation_needed) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reasoning behind this static change? If it was only a local fix could we remove and test that the build does not fail?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Radu2k , as mentioned this is just reversal of an unintended change in out PR. We have not done any additional changes ourselves. This was present before our PR was merged, so we have just restored it as is.

@Shreyas-fuj
Copy link
Contributor Author

@mgouicem
I have squashed, renamed and pushed the commit, thanks.

Radu2k
Radu2k approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@Radu2k Radu2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@theComputeKid
Copy link
Contributor

Going to check perf on g3 and then will approve.

@Shreyas-fuj
Copy link
Contributor Author

Going to check perf on g3 and then will approve.

Hi @theComputeKid , any update on this? Thanks.

@mgouicem mgouicem merged commit 41c2804 into oneapi-src:main Sep 30, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzarukin dzarukin dzarukin approved these changes

@mgouicem mgouicem mgouicem approved these changes

@theComputeKid theComputeKid theComputeKid approved these changes

@Radu2k Radu2k Radu2k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Shreyas-fuj @mgouicem @theComputeKid @Radu2k @dzarukin