Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchdnn: doc: add newly add f8_e4m3 and f8_e5m2 #2201

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

benchdnn: doc: add newly add f8_e4m3 and f8_e5m2 #2201

wants to merge 3 commits into from

Conversation

airMeng
Copy link

@airMeng airMeng commented Nov 7, 2024

Description

F8_E4M3 and F8_E5M2 have been introduced into OneDNN but missed in benchdnn doc.

Fixes # (github issue)

Checklist

General

  • Do all unit and benchdnn tests (make test and make test_benchdnn_*) pass locally for each commit?
  • Have you formatted the code using clang-format?

Performance improvements

  • Have you submitted performance data that demonstrates performance improvements?

New features

  • Have you published an RFC for the new feature?
  • Was the RFC approved?
  • Have you added relevant tests?

Bug fixes

  • Have you included information on how to reproduce the issue (either in a github issue or in this PR)?
  • Have you added relevant regression tests?

RFC PR

  • Does RFC document follow the template?
  • Have you added a link to the rendered document?

@airMeng airMeng requested review from a team as code owners November 7, 2024 03:25
@github-actions github-actions bot added the documentation A request to change/fix/improve the documentation. Codeowner: @oneapi-src/onednn-doc label Nov 7, 2024
@airMeng
Copy link
Author

airMeng commented Nov 11, 2024

@dzarukin Could you give a review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzarukin dzarukin dzarukin approved these changes

@mgouicem mgouicem mgouicem approved these changes

Assignees
No one assigned
Labels
documentation A request to change/fix/improve the documentation. Codeowner: @oneapi-src/onednn-doc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@airMeng @mgouicem @dzarukin