-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[L0 provider] log each call to L0 #1068
base: main
Are you sure you want to change the base?
Conversation
using a special format that SYCL tests rely on
@igchor LGTM, but I think changes made for specific clients should be avoided or we should make it more configurable, but I don't have a simple idea how to do that |
Yeah, I know this is not ideal. I will be trying to get rid of log parsing logic from SYCL so that we do not have to follow a specific format in future (but this might take some time, until all the tests are fixed). |
BTW, you are trying to log every Level Zero call. Why not to make such logging on the Level Zero side? |
Yes, eventually, I would like to have logging inside L0. However, this will require a few more fixes/changes in the loader. For now i just wanted have something that we can use with SYCL right away. |
I confused than.
Based on that I have the following questions:
|
The logging is needed not only to make SYCL tests pass but also for debugging/development (and for v2 L0 adapter to have the same capabilities as the legacy adapter). Let me mark this as draft for now and see if we can add this logging to L0 soon. If not, I will undraft the PR. |
In a format that is required by SYCL tests.
This is to match UR behavior that logs every call to L0.
Description
Checklist