Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add CUDA provider #644

Merged
merged 1 commit into from
Sep 19, 2024
Merged

add CUDA provider #644

merged 1 commit into from
Sep 19, 2024

Conversation

bratpiorka
Copy link
Contributor

@bratpiorka bratpiorka commented Jul 29, 2024 •
edited
Loading

add CUDA provider

NOTE: this PR does not add full functionality. Examples, better tests (with a unified approach to CUDA and L0 testing) and IPC functionality are still missing.

Partially fixes #225

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly
  • CI workflows, not executed per PR (e.g. Nightly), execute properly
  • New tests added, especially if they will fail without my changes
  • Added/extended example(s) to cover this functionality
  • Extended the README/documentation
  • All newly added source files have a license
  • All newly added source files are referenced in CMake files
  • Logger (with debug/info/... messages) is used

lukaszstolarczuk
lukaszstolarczuk reviewed Jul 29, 2024
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
.github/workflows/basic.yml Outdated Show resolved Hide resolved
include/umf/providers/provider_cuda.h Outdated Show resolved Hide resolved
@bratpiorka bratpiorka force-pushed the rrudnick_cuda_provider branch 3 times, most recently from e08294d to ea08f87 Compare August 5, 2024 15:37
@bratpiorka bratpiorka force-pushed the rrudnick_cuda_provider branch 7 times, most recently from e651a1a to 7eb4364 Compare August 7, 2024 08:20
lukaszstolarczuk
lukaszstolarczuk reviewed Aug 7, 2024
View reviewed changes
src/CMakeLists.txt Outdated Show resolved Hide resolved
.github/workflows/gpu.yml Outdated Show resolved Hide resolved
@bratpiorka bratpiorka force-pushed the rrudnick_cuda_provider branch 3 times, most recently from 12c6784 to 69aaabe Compare August 9, 2024 12:14
@bratpiorka bratpiorka marked this pull request as ready for review August 9, 2024 12:14
@bratpiorka bratpiorka requested a review from a team as a code owner August 9, 2024 12:14
@bratpiorka bratpiorka requested a review from lplewa August 9, 2024 13:35
@bratpiorka bratpiorka force-pushed the rrudnick_cuda_provider branch 7 times, most recently from b627282 to 313dfa0 Compare September 6, 2024 16:10
@bratpiorka bratpiorka force-pushed the rrudnick_cuda_provider branch 2 times, most recently from 1434321 to c8eebe7 Compare September 16, 2024 09:10
ldorau
ldorau requested changes Sep 16, 2024
View reviewed changes
.github/workflows/gpu.yml Outdated Show resolved Hide resolved
.github/workflows/gpu.yml Outdated Show resolved Hide resolved
.github/workflows/pr_push.yml Outdated Show resolved Hide resolved
test/CMakeLists.txt Show resolved Hide resolved
ldorau
ldorau reviewed Sep 16, 2024
View reviewed changes
CMakeLists.txt Show resolved Hide resolved
ldorau
ldorau requested changes Sep 16, 2024
View reviewed changes
benchmark/CMakeLists.txt Show resolved Hide resolved
examples/CMakeLists.txt Show resolved Hide resolved
src/provider/provider_cuda.c Outdated Show resolved Hide resolved
src/provider/provider_cuda.c Outdated Show resolved Hide resolved
src/provider/provider_cuda.c Outdated Show resolved Hide resolved
src/provider/provider_cuda.c Show resolved Hide resolved
src/provider/provider_cuda.c Show resolved Hide resolved
src/provider/provider_cuda.c Show resolved Hide resolved
ldorau
ldorau requested changes Sep 17, 2024
View reviewed changes
src/provider/provider_cuda.c Outdated Show resolved Hide resolved
src/provider/provider_cuda.c Outdated Show resolved Hide resolved
test/providers/cuda_helpers.cpp Outdated Show resolved Hide resolved
@bratpiorka bratpiorka force-pushed the rrudnick_cuda_provider branch 2 times, most recently from 52db993 to 7784378 Compare September 17, 2024 07:45
ldorau
ldorau requested changes Sep 17, 2024
View reviewed changes
examples/CMakeLists.txt Show resolved Hide resolved
ldorau
ldorau reviewed Sep 17, 2024
View reviewed changes
test/CMakeLists.txt Outdated Show resolved Hide resolved
ldorau
ldorau reviewed Sep 17, 2024
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
ldorau
ldorau reviewed Sep 17, 2024
View reviewed changes
CMakeLists.txt Outdated Show resolved Hide resolved
ldorau
ldorau requested changes Sep 17, 2024
View reviewed changes
src/provider/provider_cuda.c Outdated Show resolved Hide resolved
src/provider/provider_cuda.c Outdated Show resolved Hide resolved
src/provider/provider_cuda.c Outdated Show resolved Hide resolved
src/provider/provider_cuda.c Outdated Show resolved Hide resolved
src/provider/provider_cuda.c Outdated Show resolved Hide resolved
lplewa
lplewa approved these changes Sep 18, 2024
View reviewed changes
src/provider/provider_cuda.c Outdated Show resolved Hide resolved
src/provider/provider_cuda.c Show resolved Hide resolved
@bratpiorka bratpiorka merged commit 3d38be5 into oneapi-src:main Sep 19, 2024
72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldorau ldorau ldorau approved these changes

@lplewa lplewa lplewa approved these changes

@vinser52 vinser52 Awaiting requested review from vinser52

@lukaszstolarczuk lukaszstolarczuk Awaiting requested review from lukaszstolarczuk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

USM support
5 participants
@bratpiorka @vinser52 @ldorau @lplewa @lukaszstolarczuk