-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add size validation for USM device/shared allocs #2557
Conversation
90776d2
to
a57191a
Compare
I don't think we can reliably have this check due to limitations in how the different adapters report max alloc size. |
What do you mean? The spec says that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CUDA/HIP LGTM
a57191a
to
fec53b0
Compare
fec53b0
to
5f12d93
Compare
Unified Runtime -> intel/llvm Repo Move NoticeInformationThe source code of Unified Runtime has been moved to intel/llvm under the unified-runtime top-level directory, The code will be mirrored to oneapi-src/unified-runtime and the specification will continue to be hosted at oneapi-src.github.io/unified-runtime. The contribution guide has been updated with new instructions for contributing to Unified Runtime. PR MigrationAll open PRs including this one will be labelled auto-close and shall be automatically closed after 30 days. Should you wish to continue with your PR you will need to migrate it to intel/llvm. This is an automated comment. |
The spec states that an allocation size higher than `DEVICE_INFO_MAX_MEM_ALLOC_SIZE` should report an error. This has been added to the Cuda, Hip and Native CPU backends now. The tests have also been updated, which sadly introduces a new regression for level zero.
5f12d93
to
532bd1c
Compare
The spec states that an allocation size higher than
DEVICE_INFO_MAX_MEM_ALLOC_SIZE
should report an error. This has beenadded to the cuda, hip and native cpu backends now.
The tests have also been updated, which sadly introduces a new
regression for level zero.