Use the correct cacheKey of local files for AVAssetImageDataProvider
#2158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #1825, we fixed an issue that the cache does not work for local files when debugging: the reason was Xcode is trying to copy the app to a new sandbox location when debugging. So the resources inside the app bundle has a different local file URL.
In that issue, we fixed the cases for local images, but not yet for the
AVAssetImageDataProvider, which still used the plainabsoluteStringas the cache key. Here we switched to use theurl.cacheKey, which also considering the sandbox changing into account.This should fix #2002