Merge pull request #10 from open-runtimes/fix-maintenance-task

fix: delete active runtimes from the swoole table on failure
open-runtimes · Nov 10, 2022 · 8d3da33 · 8d3da33
2 parents c2cac12 + 7e80e2d
commit 8d3da33
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/app/http.php b/app/http.php
@@ -921,11 +921,11 @@ function (string $runtimeId, string $payload, array $variables, int $timeout, st
                         $connection = $orchestrationPool->pop();
                         $orchestration = $connection->getResource();
                         $orchestration->remove($runtime['name'], true);
-                        $activeRuntimes->del($activeRuntimeId);
                         Console::success("Successfully removed {$runtime['name']}");
                     } catch (\Throwable $th) {
                         Console::error('Inactive Runtime deletion failed: ' . $th->getMessage());
                     } finally {
+                        isset($connection) && $activeRuntimes->del($activeRuntimeId);
                         isset($connection) && $connection->reclaim();
                     }
                 });