Add unit tests to instrumentation webhook #3840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iblancasa
approved these changes
Mar 24, 2025
swiatekm
reviewed
Mar 24, 2025
| assert.Equal(t, "dotnet-img:1", inst.Spec.DotNet.Image) | ||
| assert.Equal(t, "apache-httpd-img:1", inst.Spec.ApacheHttpd.Image) | ||
| assert.Equal(t, "nginx-img:1", inst.Spec.Nginx.Image) | ||
| tests := []struct { |
There was a problem hiding this comment.
I think I preferred the way this test was written previously. You're right to want to add tests for other cases, but I'd prefer these to be plain subtests with unique assertions. Then you can have a test to check the resource override, and only assert that the override applies, instead of needing to include the whole instrumentation spec as an expected return value. Does that make sense?
There was a problem hiding this comment.
@swiatekm Thank you for your feedback! I've fixed the PR so could you take a look at it again when you have time?
swiatekm
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I've added missing unit tests to apis/v1alpha1/instrumentation_webhook_test.go. Thanks for the review!
Link to tracking Issue(s):
N/A
Testing:
Documentation:
Do I need to create a changelog for this change? 🤔