Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24] - Add user confirmation prompt (Y/N) before cleanup mode using case $confirm #52

Closed
wants to merge 1 commit into from

Conversation

Abhinavcode13
Copy link
Collaborator

@Abhinavcode13 Abhinavcode13 commented Jul 6, 2024

Addresses : #24

@Abhinavcode13 Abhinavcode13 changed the title (feat) Add user confirmation prompt before cleanup mode (feat) Add user confirmation prompt (Y/N) before cleanup mode using case $confirm Jul 6, 2024
@elijah0kello
Copy link
Collaborator

We resolved that we do not need interactivity in the script. Me and @tdaly61

So unfortunately , I don't think we need this. Thanks for the effort though

@tdaly61
Copy link
Collaborator

tdaly61 commented Jul 8, 2024

yeah I agree with @elijah0kello at least for the near term, once we have more production like deployments using Mojafos then I think there will be arguments for safeguards BUT for now we want to avoid interactivity

@Abhinavcode13 Abhinavcode13 changed the title (feat) Add user confirmation prompt (Y/N) before cleanup mode using case $confirm [24] - Add user confirmation prompt (Y/N) before cleanup mode using case $confirm Jul 12, 2024
@Abhinavcode13 Abhinavcode13 deleted the cleanup-condition branch July 23, 2024 08:46
@Abhinavcode13
Copy link
Collaborator Author

Deprecated not needed as of now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants