-
-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(ja): update Japanese docs (08/17/2024 ~ 09/21/2024) #1924
docs(ja): update Japanese docs (08/17/2024 ~ 09/21/2024) #1924
Conversation
|
docs/ja/openapi-fetch/api.md
Outdated
@@ -180,6 +181,15 @@ const { data, error } = await client.PUT("/submit", { | |||
}); | |||
``` | |||
|
|||
::: tip | |||
|
|||
便宜上、 `openapi-fetch` は `body` パラメーターに値が指定されたリクエストに対して、`Content-Type` を自動的に `application/json` に設定します。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just an idea to avoid duplicated "に"
便宜上、 `openapi-fetch` は `body` パラメーターに値が指定されたリクエストに対して、`Content-Type` を自動的に `application/json` に設定します。 | |
便宜上、 `openapi-fetch` は `body` パラメーターに値が指定されたリクエストに対して、`Content-Type` を `application/json` に自動で設定します。 |
docs/ja/examples.md
Outdated
if (typeof status === "number") { | ||
// status >= 400 | ||
} else if (api.isAxiosError(error)) { | ||
// リクエスト失敗(例:ネットワークエラー |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nits
// リクエスト失敗(例:ネットワークエラー | |
// リクエスト失敗(例:ネットワークエラー) |
docs/ja/examples.md
Outdated
|
||
// 例1. "axios"(デフォルト)のステータス処理方法での使用 (validStatus: 'axios') | ||
|
||
// axiosのようにエラーを投げる(例:status >= 400、ネットワークエラー、インターセプターエラー) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO "エラーを投げる" sounds slightly casual, "スローする" is used widely than the former.
// axiosのようにエラーを投げる(例:status >= 400、ネットワークエラー、インターセプターエラー) | |
// axiosのようにエラーをスローする(例:status >= 400、ネットワークエラー、インターセプターエラー) |
Applied review suggestions, thanks for the quick review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the improvements! 🙏
Changes
I have updated the Japanese documentation that had not been updated, based on the changes made to the English documentation between August 17th, when the Japanese documentation was added #1855 , and September 21st.
I'm not sure if all updates were caught, but I identified the files updated during the specified period using the following method and updated the differences.
How to Review
I’m thinking of asking @siketyan to review if there are any inappropriate expressions.
Checklist
docs/
updated (if necessary)pnpm run update:examples
run (only applicable for openapi-typescript)