Categories belongig to a series: Duplicated Labels #645
Conversation
|
Thx for the update. I'm looking forward to hearing here about the results of your discussion. |
|
@dagraf can you quickly confirm or refute something for me? When we switch a series category to a video category, all the videos currently in the series are supposed to keep said category around, right? |
No, they should loose the said category. This is what happens right now on our productive annotation tool installation and I would expect to keep this behavior. If for example, an admin makes a category belonging to series by mistake and changes it later to an event category, this admin would be forced to delete the kept categories in all videos. But: What we should keep are the already set annotations which where created using this said category. What is your opinion here? |
|
Interesting, but that's good, that would simplify things, thanks! I'm still working my way through all the intricacies of the problem, this one's a real doozy. 😵💫 The changes required to fix this properly will be rather extensive, though, and while I try to work these out I'm also looking out for any kind of quick fix we can apply in the meantime. I'll got back to y'all here once I have a grasp of the full picture. |
This PR-Draft relates to #634 and #601 .
I "fixed" the current implementation in a way that the labels view now should not be showing duplicated labels anymore.
However, the implemenation is still majorly flawed as indicated in the comments:
https://github.com/jduehring/annotation-tool/blob/0cb527bdaf654e287a1f4ecbfa927d0f9a546bc3/opencast-backend/annotation-impl/src/main/java/org/opencast/annotation/impl/persistence/ExtendedAnnotationServiceJpaImpl.java#L967C9-L969C145
When updating the labels for a series from the master series category, they currently are beeing deleted and newly created each time the app gets refreshed. But since the app tries to keep track of deleted labels, they essentially get duplicated in the background (which can still be seen in the "edit category" view) .
We could probably try to filter all deleted labels and only show the newly created ones, but that doesnt fix the underlying issue of creating more and more (deleted) labels each refresh. Ideally the labels should only be created once and only update, if new lables have been created in the master series category. Unfortunately that does'nt seem as straight forward as it sounds.
I could not implement a working, satisfying solution yet and will discuss this matter with @JulianKniephoff and/or @mwygas in January to hopefully make quick progress here.