Live linting/type checking #712
Comments
JulianKniephoff
added a commit
to JulianKniephoff/opencast-admin-interface
that referenced
this issue
Jun 19, 2024
I removed our leftover config in opencast#700 with a promise to bring ESLint back. Well this is it, for now! This introduces an ESLint config file in the new flat file format, which will be required for ESLint `>= 9`. It is already supported in version 8, though, which we are still stuck on because of the (unmaintained) config we are/were using. I briefly tried to port this project over to `@opencast/eslint-config-ts-react`, but the code said "no," basically. ;P This has a few unfortunate consequences. See opencast#713. I plan to address these in due time, though. Note that this does **not** introduce automatic/live checking of the code during development. I only added a call to the linter to the build command, in turn making CI fail when there are warnings. I created opencast#712 to track the live thing if we want that.
JulianKniephoff
added a commit
to JulianKniephoff/opencast-admin-interface
that referenced
this issue
Jun 25, 2024
I removed our leftover config in opencast#700 with a promise to bring ESLint back. Well this is it, for now! This introduces an ESLint config file in the new flat file format, which will be required for ESLint `>= 9`. It is already supported in version 8, though, which we are still stuck on because of the (unmaintained) config we are/were using. I briefly tried to port this project over to `@opencast/eslint-config-ts-react`, but the code said "no," basically. ;P This has a few unfortunate consequences. See opencast#713. I plan to address these in due time, though. Note that this does **not** introduce automatic/live checking of the code during development. I only added a call to the linter to the build command, in turn making CI fail when there are warnings. I created opencast#712 to track the live thing if we want that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Linting and type checking currently only happens when creating a build. This also happens in CI, so we will catch errors eventually, but it would be a better DX if we tightened that feedback loop.
Unfortunately, Vite seems to think it idiomatic to keep that stuff out of the build system, so it's questionable how we want to implement it. This position is supported by
vite-plugin-eslintbeing all but dead, basically. There isvite-plugin-checker, which Vite also mentions on their website, but I haven't looked into it, yet.Of course we could also provide IDE integration (if todays IDEs aren't smart enough to pick up on the ESLint config already anyway) or custom scripts as npm-scripts or like we do in Tobira. 🤔
The text was updated successfully, but these errors were encountered: