"Restore" ESLint support #714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulianKniephoff
added
the
type:code-enhancement
|
This pull request is deployed at test.admin-interface.opencast.org/714/2024-06-25_16-18-46/ . |
|
Use Run test server using develop.opencast.org as backend: Specify a different backend like stable.opencast.org: It may take a few seconds for the interface to spin up. |
Arnei
approved these changes
Jun 20, 2024
This comment was marked as resolved.
This comment was marked as resolved.
I removed our leftover config in opencast#700 with a promise to bring ESLint back. Well this is it, for now! This introduces an ESLint config file in the new flat file format, which will be required for ESLint `>= 9`. It is already supported in version 8, though, which we are still stuck on because of the (unmaintained) config we are/were using. I briefly tried to port this project over to `@opencast/eslint-config-ts-react`, but the code said "no," basically. ;P This has a few unfortunate consequences. See opencast#713. I plan to address these in due time, though. Note that this does **not** introduce automatic/live checking of the code during development. I only added a call to the linter to the build command, in turn making CI fail when there are warnings. I created opencast#712 to track the live thing if we want that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed our leftover config in #700 with a promise to bring ESLint back.
Well this is it, for now!
This introduces an ESLint config file in the new flat file format,
which will be required for ESLint
>= 9. It is already supported in version 8, though,which we are still stuck on because of the (unmaintained) config we are/were using.
I briefly tried to port this project over to
@opencast/eslint-config-ts-react,but the code said "no," basically. ;P
This has a few unfortunate consequences. See #713. I plan to address these in due time, though.
Note that this does not introduce automatic/live checking of the code
during development. I only added a call to the linter to the build command,
in turn making CI fail when there are warnings.
I created #712 to track the live thing if we want that.