Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add noUncheckedIndexedAccess to tsconfig #725

Open
Arnei opened this issue Jun 20, 2024 · 0 comments · May be fixed by #732
Open

Add noUncheckedIndexedAccess to tsconfig #725

Arnei opened this issue Jun 20, 2024 · 0 comments · May be fixed by #732
Labels
type:code-enhancement Internal improvements to the codebase

Comments

@Arnei
Copy link
Member

Arnei commented Jun 20, 2024

The issue described in #715 could have been prevented by enabling noUncheckedIndexedAccess in our tsconfig.json. Investigate whether noUncheckedIndexedAccess is actually beneficial to our codebase and if so, introduce it.

At any rate, introducing this would require some work:

Found 347 errors in 48 files.
@Arnei Arnei added the type:code-enhancement Internal improvements to the codebase label Jun 20, 2024
Arnei added a commit to Arnei/opencast-admin-interface that referenced this issue Jun 24, 2024
@Arnei
Add noUncheckedIndexedAccess to tsconfig
4a5c7d9 
Adds the flag `noUncheckedIndexedAccess` to our
typescript configuration file. Also addresses the
errors reported by the flag.

Does come with some false positives, but their numbers
are low enough that the benefits do outweigh
addressing them.

Resolves opencast#725.
@Arnei Arnei linked a pull request Jun 24, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:code-enhancement Internal improvements to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add noUncheckedIndexedAccess to tsconfig Arnei/opencast-admin-interface
1 participant
@Arnei