Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add noUncheckedIndexedAccess to tsconfig #732

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Add noUncheckedIndexedAccess to tsconfig #732

wants to merge 8 commits into from

Conversation

Arnei
Copy link
Member

@Arnei Arnei commented Jun 24, 2024

Adds the flag noUncheckedIndexedAccess to our typescript configuration file. Also addresses the errors reported by the flag.

Does come with some false positives, but their numbers are low enough that the benefits do outweigh addressing them.

Resolves #725.

@Arnei
Add noUncheckedIndexedAccess to tsconfig
4a5c7d9 
Adds the flag `noUncheckedIndexedAccess` to our
typescript configuration file. Also addresses the
errors reported by the flag.

Does come with some false positives, but their numbers
are low enough that the benefits do outweigh
addressing them.

Resolves opencast#725.
@Arnei Arnei added the type:typing Add typing label Jun 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 24, 2024 •
edited
Loading

This pull request is deployed at test.admin-interface.opencast.org/732/2024-07-30_13-55-21/ .
It might take a few minutes for it to become available.

@github-actions GitHub Actions
Copy link
Contributor

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-732

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-732

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 1, 2024

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@Arnei Arnei force-pushed the noUncheckedIndexedAccess-addition branch from cab599c to a863c39 Compare July 1, 2024 07:45
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 9, 2024

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status:conflicts type:typing Add typing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add noUncheckedIndexedAccess to tsconfig
1 participant
@Arnei