Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix end time date display for scheduling #1158

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Arnei
Copy link
Member

@Arnei Arnei commented Mar 17, 2025

Fixes display behaviour for the end time date display on the scheduling pages to go back to how it was before.
Namely the end time date is now again displayed in the same row as the end time, and is only actually displayed if the end time is "before" the start time (at which the ui assumes that the end time has to be on the next day).

Bildschirmfoto vom 2025-03-17 11-37-10

How to test this

Can be tested as usual. Should only affect the scheduling pages in the create new event modal and event details modal.

Fixes display behaviour for the end time date display on the scheduling
pages to go back to how it was before.
Namely the end time date is now again displayed in the same row
as the end time, and is only actually displayed if the end time is
"before" the start time (at which the ui assumes that the end time has
to be on the next day).
@Arnei Arnei added the type:visual-clarity Improves UI readability label Mar 17, 2025
Copy link
Contributor

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-1158

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-1158

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

Copy link
Contributor

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

Copy link
Contributor

github-actions bot commented Mar 19, 2025

This pull request is deployed at test.admin-interface.opencast.org/1158/2025-03-20_13-42-58/ .
It might take a few minutes for it to become available.

Copy link
Contributor

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:visual-clarity Improves UI readability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant