Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nested buttons in dropdown warning #1160

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Arnei
Copy link
Member

@Arnei Arnei commented Mar 18, 2025

Fixes #1156.

Fixes a console warning for the table size dropdown and the bottom right of most pages. Also slightly fixes the CSS
to avoid overlapping of elements.

Warning this fixes:
Bildschirmfoto vom 2025-03-18 10-00-58

Before:
Bildschirmfoto vom 2025-03-18 09-59-53

After:
Bildschirmfoto vom 2025-03-18 09-59-44

How to test this

Can be tested as usual.

Fixes a console warning for the table size dropdown and the bottom right
of most pages. Also slightly fixes the CSS
to avoid overlapping of elements
@Arnei Arnei added the type:bug Something isn't working label Mar 18, 2025
Copy link
Contributor

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-1160

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-1160

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

Copy link
Contributor

This pull request is deployed at test.admin-interface.opencast.org/1160/2025-03-20_12-50-05/ .
It might take a few minutes for it to become available.

Copy link

@NadiaUoM NadiaUoM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verify all the relevant pages working as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTML broken for table items dropdown
2 participants