Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect publication channels listprovider more #738

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Respect publication channels listprovider more #738

wants to merge 7 commits into from

Conversation

Arnei
Copy link
Member

@Arnei Arnei commented Jun 25, 2024 •
edited
Loading

While we were already getting information on publications from the respective listprovider for the event details, we were not putting all of it to use, for example ordering. Also, the event table did not have access to this information at all. This should fix that.

Helps with #409.

Screenshots, as the effects are rather unnoticeable without making changes to the listprovider.
Bildschirmfoto vom 2024-06-25 12-29-25
Bildschirmfoto vom 2024-06-25 12-29-41

This PR over in the main repository may also be of interest: opencast/opencast#5956

@Arnei
Respect publication channels listprovider more
2341b61 
While we were already getting information on
publications from the respective listprovider for
the event details, we were not putting all of it to
use, for example ordering. Also, the event table
did not have access to this information at all.
This should fix that.
@Arnei Arnei added the type:bug Something isn't working label Jun 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-738

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-738

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 25, 2024 •
edited
Loading

This pull request is deployed at test.admin-interface.opencast.org/738/2024-07-16_15-33-04/ .
It might take a few minutes for it to become available.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 1, 2024

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@Arnei Arnei force-pushed the publication-channels-listprovider branch from ef58a81 to 1ddd1fa Compare July 1, 2024 07:32
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 9, 2024

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 9, 2024

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Arnei