Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make add event modal more accessible #745

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

make add event modal more accessible #745

wants to merge 3 commits into from

Conversation

rlucke
Copy link
Contributor

@rlucke rlucke commented Jun 26, 2024

adding aria-labels, use buttons instead of divs and add some texts for screen readers

@rlucke rlucke added the type:accessibility This would help impaired users label Jun 26, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@github-actions GitHub Actions
Copy link
Contributor

Hi @rlucke
Thank you for contributing to the Opencast Editor.
We noticed that you have not yet filed an Individual Contributor License Agreement. Doing that (once) helps us to ensure that Opencast stays free for all. If you make your contribution on behalf of an institution, you might also want to file a Corporate Contributor License Agreement (giving you as individual contributor a bit more security as well). It can take a while for this bot to find out about new filings, so if you just filed one or both of the above do not worry about this message!
Please let us know if you have any questions regarding the CLA.

@github-actions GitHub Actions
Copy link
Contributor

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-745

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-745

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 26, 2024 •
edited
Loading

This pull request is deployed at test.admin-interface.opencast.org/745/2024-06-26_14-13-04/ .
It might take a few minutes for it to become available.

Arnei
Arnei reviewed Jun 28, 2024
View reviewed changes
Copy link
Member

@Arnei Arnei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can access more things by keyboard navigation and the screenreader shouts much less nonsense and more actually useful information, I love it.

Overall very minor issues below:

src/components/events/partials/ModalTabsAndPages/NewAccessPage.tsx
@@ -120,7 +121,7 @@ const NewAccessPage = ({

{/* Template selection*/}
<div className="obj tbl-list">
<table className="main-tbl">
<table className="main-tbl" role="presentation">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use role="none" instead, or is that not yet supported well enough?

src/components/events/partials/ModalTabsAndPages/NewAccessPage.tsx Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 2, 2024

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arnei Arnei Arnei left review comments

Assignees
No one assigned
Labels
status:conflicts type:accessibility This would help impaired users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rlucke @Arnei