Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optional terms of use dialog for user #825
base: main
Are you sure you want to change the base?
Optional terms of use dialog for user #825
Changes from all commits
73596e2
7a6a15d
cb568cf
4ea9ccf
4a8c71d
2005f13
20a2a76
f6fae19
6f20599
acaab2c
dd13fa7
3f0ec7d
55dad2f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't quite working right. I can see it requesting my region's terms (which correctly 404), and I can see it calling
setTermsContent
with the correct en-US terms. But the modal itself never pops up.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine for me, what user are you trying this with?
ROLE_ADMIN
will never see this, also the propertyorg.opencastproject.admin.display_terms
has to be true