Update and enforce eslint #1558
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates eslint to major version 9 and removes other eslint dependencies that are obsolete. Furthermore, adds typescript and eslint checks to the build command, so that warnings and errors must be addressed. Finally, makes the minimum amount of code changes for this to build. Currently ignored eslint rules may be enabled by subsequent commits/pull requests.
Arnei
added
type:dependencies
|
This pull request is deployed at test.editor.opencast.org/1558/2025-02-25_11-34-43/ . |
|
So, I'm thinking that #1134 is related here. Can we enforce the tabs vs spaces debate here too? Sounds like everything else (editor, tobira, OC itself) is all spaces, so enforcing a spaces change with this might make sense. |
|
I don't see how that PR is related at all, maybe you got the wrong number? Also this PR enforces the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates eslint to major version 9 and removes other eslint dependencies that are obsolete. Furthermore, adds typescript and eslint checks to the build command, so that warnings and errors must be addressed. Finally, makes the minimum amount of code changes for this to build. Currently ignored eslint rules may be enabled by subsequent commits/pull requests.