Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove or change branded test files in thumbnail service #122

Merged
merged 2 commits into from
Jan 28, 2025
Merged

chore: remove or change branded test files in thumbnail service #122

merged 2 commits into from
Jan 28, 2025

Conversation

JammingBen
Copy link
Contributor

@JammingBen JammingBen commented Jan 27, 2025 •
edited
Loading

  • Replaces mp3 test files because they had branded meta data
  • Replaces test images that had a logo before
  • Removes unused test.ggp test file

@JammingBen JammingBen force-pushed the chore/branding-thumnails-test-data branch from a8f9d18 to fac4ebb Compare January 27, 2025 14:12
@JammingBen JammingBen requested a review from butonic January 27, 2025 14:14
@butonic
Copy link
Contributor

butonic commented Jan 27, 2025 •
edited by JammingBen
Loading

  • can you double check the test files? images should not show a logo ...

@JammingBen JammingBen merged commit 2857b6d into main Jan 28, 2025
1 check failed
@JammingBen JammingBen deleted the chore/branding-thumnails-test-data branch January 28, 2025 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@butonic butonic butonic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JammingBen @butonic