Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add minor Makefile improvements #51

Merged
merged 4 commits into from
Oct 2, 2024
Merged

Add minor Makefile improvements #51

merged 4 commits into from
Oct 2, 2024

Conversation

compor
Copy link
Contributor

@compor compor commented Sep 19, 2024

This PR adds minor improvements (mostly DRY-specific) to the Makefile:

  • Define the TeX filenames once and use their variables everywhere else needed
  • Declare all phony targets

@compor compor added the enhancement New feature or request label Sep 19, 2024
@compor compor self-assigned this Sep 19, 2024
@compor compor changed the title Add minor Makefile imporovements Add minor Makefile improvements Sep 19, 2024
math-fehr
math-fehr approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@math-fehr math-fehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup, thanks!

@math-fehr math-fehr merged commit 0cd1348 into main Oct 2, 2024
4 checks passed
@math-fehr math-fehr deleted the christos/polish-makefile branch October 2, 2024 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@math-fehr math-fehr math-fehr approved these changes

@tobiasgrosser tobiasgrosser Awaiting requested review from tobiasgrosser

Assignees

@compor compor

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@compor @math-fehr