Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Turn on gapi tests on ARM64 #57

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 21 additions & 8 deletions .github/workflows/OCV-Contrib-PR-4.x-ARM64.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -69,18 +69,23 @@ jobs:
- name: Clone opencv
timeout-minutes: 60
run: git clone --single-branch --branch ${{ env.TARGET_BRANCH_NAME }} --reference ${{ env.GIT_CACHE_DOCKER }}/opencv.git https://github.com/opencv/opencv.git $HOME/opencv
# - name: Merge opencv with ${{ env.SOURCE_BRANCH_NAME }} branch
# timeout-minutes: 60
# if: ${{ github.event.repository.name != 'ci-gha-workflow' }}
# run: |
# OPENCV_FORK=$(git ls-remote --heads "https://github.com/${{ env.PR_AUTHOR }}/opencv" "${{ env.SOURCE_BRANCH_NAME }}") || true
# if [[ ! -z "$OPENCV_FORK" ]]; then
# echo "Merge opencv with ${{ env.SOURCE_BRANCH_NAME }} branch"
# cd $HOME/opencv
# git pull -v "https://github.com/${{ env.PR_AUTHOR }}/opencv" "${{ env.SOURCE_BRANCH_NAME }}"
# else
# echo "No merge since ${{ env.PR_AUTHOR }}/opencv does not have branch ${{ env.SOURCE_BRANCH_NAME }}"
# fi
- name: Merge opencv with ${{ env.SOURCE_BRANCH_NAME }} branch
timeout-minutes: 60
if: ${{ github.event.repository.name != 'ci-gha-workflow' }}
run: |
OPENCV_FORK=$(git ls-remote --heads "https://github.com/${{ env.PR_AUTHOR }}/opencv" "${{ env.SOURCE_BRANCH_NAME }}") || true
if [[ ! -z "$OPENCV_FORK" ]]; then
echo "Merge opencv with ${{ env.SOURCE_BRANCH_NAME }} branch"
cd $HOME/opencv
git pull -v "https://github.com/${{ env.PR_AUTHOR }}/opencv" "${{ env.SOURCE_BRANCH_NAME }}"
else
echo "No merge since ${{ env.PR_AUTHOR }}/opencv does not have branch ${{ env.SOURCE_BRANCH_NAME }}"
fi
git pull -v "https://github.com/anna-khakimova/opencv" "ak/fix_resize4lpi_tests"
- name: Clone opencv_extra
timeout-minutes: 60
run: git clone --single-branch --branch ${{ env.TARGET_BRANCH_NAME }} --reference ${{ env.GIT_CACHE_DOCKER }}/opencv_extra.git https://github.com/opencv/opencv_extra.git $HOME/opencv_extra
Expand Down Expand Up @@ -175,6 +180,10 @@ jobs:
timeout-minutes: 60
if: ${{ always() && steps.build-opencv-contrib.outcome == 'success' }}
run: cd $HOME/build && xvfb-run -a bin/opencv_test_fuzzy --gtest_filter=${{ env.GTEST_FILTER_STRING }} --test_threads=${{ env.PARALLEL_JOBS }}
- name: Accuracy:gapi
timeout-minutes: 60
if: ${{ always() && steps.build-opencv-contrib.outcome == 'success' }}
run: cd $HOME/build && xvfb-run -a bin/opencv_test_gapi --gtest_filter=${{ env.GTEST_FILTER_STRING }} --test_threads=${{ env.PARALLEL_JOBS }}
- name: Accuracy:hdf
timeout-minutes: 60
if: ${{ always() && steps.build-opencv-contrib.outcome == 'success' }}
Expand Down Expand Up @@ -335,6 +344,10 @@ jobs:
timeout-minutes: 60
if: ${{ always() && steps.build-opencv-contrib.outcome == 'success' }}
run: cd $HOME/build && xvfb-run -a bin/opencv_perf_features2d --perf_impl=plain --perf_min_samples=1 --perf_force_samples=1 --perf_verify_sanity --skip_unstable=1 --gtest_filter=${{ env.GTEST_FILTER_STRING }} --perf_threads=${{ env.PARALLEL_JOBS }}
- name: Performance:gapi
timeout-minutes: 60
if: ${{ always() && steps.build-opencv-contrib.outcome == 'success' }}
run: cd $HOME/build && xvfb-run -a bin/opencv_perf_gapi --perf_impl=plain --perf_min_samples=1 --perf_force_samples=1 --perf_verify_sanity --skip_unstable=1 --gtest_filter=${{ env.GTEST_FILTER_STRING }} --perf_threads=${{ env.PARALLEL_JOBS }}
- name: Performance:imgcodecs
timeout-minutes: 60
if: ${{ always() && steps.build-opencv-contrib.outcome == 'success' }}
Expand Down
43 changes: 24 additions & 19 deletions .github/workflows/OCV-Contrib-PR-4.x-macOS-ARM64.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -58,17 +58,22 @@ jobs:
timeout-minutes: 60
run: git clone --single-branch --branch ${{ env.TARGET_BRANCH_NAME }} --reference $GIT_CACHE/opencv.git https://github.com/opencv/opencv.git
working-directory: ${{ github.workspace }}
- name: Merge opencv with ${{ env.SOURCE_BRANCH_NAME }} branch
# - name: Merge opencv with ${{ env.SOURCE_BRANCH_NAME }} branch
# timeout-minutes: 60
# if: ${{ github.event.repository.name != 'ci-gha-workflow' }}
# run: |
# OPENCV_FORK=$(git ls-remote --heads "https://github.com/${{ env.PR_AUTHOR }}/opencv" "${{ env.SOURCE_BRANCH_NAME }}") || true
# if [[ ! -z "$OPENCV_FORK" ]]; then
# echo "Merge opencv with ${{ env.SOURCE_BRANCH_NAME }} branch"
# git pull -v "https://github.com/${{ env.PR_AUTHOR }}/opencv" "${{ env.SOURCE_BRANCH_NAME }}"
# else
# echo "No merge since ${{ env.PR_AUTHOR }}/opencv does not have branch ${{ env.SOURCE_BRANCH_NAME }}"
# fi
# working-directory: ${{ github.workspace }}/opencv
- name: Merge opencv with test branch
timeout-minutes: 60
if: ${{ github.event.repository.name != 'ci-gha-workflow' }}
run: |
OPENCV_FORK=$(git ls-remote --heads "https://github.com/${{ env.PR_AUTHOR }}/opencv" "${{ env.SOURCE_BRANCH_NAME }}") || true
if [[ ! -z "$OPENCV_FORK" ]]; then
echo "Merge opencv with ${{ env.SOURCE_BRANCH_NAME }} branch"
git pull -v "https://github.com/${{ env.PR_AUTHOR }}/opencv" "${{ env.SOURCE_BRANCH_NAME }}"
else
echo "No merge since ${{ env.PR_AUTHOR }}/opencv does not have branch ${{ env.SOURCE_BRANCH_NAME }}"
fi
git pull -v "https://github.com/anna-khakimova/opencv" "ak/fix_resize4lpi_tests"
working-directory: ${{ github.workspace }}/opencv
- name: Clone opencv_extra
timeout-minutes: 60
Expand Down Expand Up @@ -179,11 +184,11 @@ jobs:
if: ${{ always() && steps.build-opencv-contrib.outcome == 'success' }}
run: ./bin/opencv_test_fuzzy --gtest_filter=${{ env.GTEST_FILTER_STRING }} --test_threads=$PARALLEL_JOBS
working-directory: ${{ github.workspace }}/build
# - name: Accuracy:gapi
# timeout-minutes: 60
# if: ${{ always() && steps.build-opencv-contrib.outcome == 'success' }}
# run: ./bin/opencv_test_gapi --gtest_filter=${{ env.GTEST_FILTER_STRING }} --test_threads=$PARALLEL_JOBS
# working-directory: ${{ github.workspace }}/build
- name: Accuracy:gapi
timeout-minutes: 60
if: ${{ always() && steps.build-opencv-contrib.outcome == 'success' }}
run: ./bin/opencv_test_gapi --gtest_filter=${{ env.GTEST_FILTER_STRING }} --test_threads=$PARALLEL_JOBS
working-directory: ${{ github.workspace }}/build
- name: Accuracy:hdf
timeout-minutes: 60
if: ${{ always() && steps.build-opencv-contrib.outcome == 'success' }}
Expand Down Expand Up @@ -384,11 +389,11 @@ jobs:
if: ${{ always() && steps.build-opencv-contrib.outcome == 'success' }}
run: ./bin/opencv_perf_features2d --perf_impl=plain --perf_min_samples=1 --perf_force_samples=1 --perf_verify_sanity --skip_unstable=1 --gtest_filter=${{ env.GTEST_FILTER_STRING }} --perf_threads=$PARALLEL_JOBS
working-directory: ${{ github.workspace }}/build
# - name: Performance:gapi
# timeout-minutes: 60
# if: ${{ always() && steps.build-opencv-contrib.outcome == 'success' }}
# run: ./bin/opencv_perf_gapi --perf_impl=plain --perf_min_samples=1 --perf_force_samples=1 --perf_verify_sanity --skip_unstable=1 --gtest_filter=${{ env.GTEST_FILTER_STRING }} --perf_threads=$PARALLEL_JOBS
# working-directory: ${{ github.workspace }}/build
- name: Performance:gapi
timeout-minutes: 60
if: ${{ always() && steps.build-opencv-contrib.outcome == 'success' }}
run: ./bin/opencv_perf_gapi --perf_impl=plain --perf_min_samples=1 --perf_force_samples=1 --perf_verify_sanity --skip_unstable=1 --gtest_filter=${{ env.GTEST_FILTER_STRING }} --perf_threads=$PARALLEL_JOBS
working-directory: ${{ github.workspace }}/build
- name: Performance:imgcodecs
timeout-minutes: 60
if: ${{ always() && steps.build-opencv-contrib.outcome == 'success' }}
Expand Down
8 changes: 8 additions & 0 deletions .github/workflows/OCV-Contrib-PR-5.x-ARM64.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,10 @@ jobs:
timeout-minutes: 60
if: ${{ always() && steps.build-opencv-contrib.outcome == 'success' }}
run: cd $HOME/build && xvfb-run -a bin/opencv_test_fuzzy --gtest_filter=${{ env.GTEST_FILTER_STRING }} --test_threads=${{ env.PARALLEL_JOBS }}
- name: Accuracy:gapi
timeout-minutes: 60
if: ${{ always() && steps.build-opencv-contrib.outcome == 'success' }}
run: cd $HOME/build && xvfb-run -a bin/opencv_test_gapi --gtest_filter=${{ env.GTEST_FILTER_STRING }} --test_threads=${{ env.PARALLEL_JOBS }}
- name: Accuracy:hdf
timeout-minutes: 60
if: ${{ always() && steps.build-opencv-contrib.outcome == 'success' }}
Expand Down Expand Up @@ -347,6 +351,10 @@ jobs:
timeout-minutes: 60
if: ${{ always() && steps.build-opencv-contrib.outcome == 'success' }}
run: cd $HOME/build && xvfb-run -a bin/opencv_perf_features2d --perf_impl=plain --perf_min_samples=1 --perf_force_samples=1 --perf_verify_sanity --skip_unstable=1 --gtest_filter=${{ env.GTEST_FILTER_STRING }} --perf_threads=${{ env.PARALLEL_JOBS }}
- name: Performance:gapi
timeout-minutes: 60
if: ${{ always() && steps.build-opencv-contrib.outcome == 'success' }}
run: cd $HOME/build && xvfb-run -a bin/opencv_perf_gapi --perf_impl=plain --perf_min_samples=1 --perf_force_samples=1 --perf_verify_sanity --skip_unstable=1 --gtest_filter=${{ env.GTEST_FILTER_STRING }} --perf_threads=${{ env.PARALLEL_JOBS }}
- name: Performance:imgcodecs
timeout-minutes: 60
if: ${{ always() && steps.build-opencv-contrib.outcome == 'success' }}
Expand Down
20 changes: 10 additions & 10 deletions .github/workflows/OCV-Contrib-PR-5.x-macOS-ARM64.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -183,11 +183,11 @@ jobs:
if: ${{ always() && steps.build-opencv-contrib.outcome == 'success' }}
run: ./bin/opencv_test_fuzzy --gtest_filter=${{ env.GTEST_FILTER_STRING }} --test_threads=$PARALLEL_JOBS
working-directory: ${{ github.workspace }}/build
# - name: Accuracy:gapi
# timeout-minutes: 60
# if: ${{ always() && steps.build-opencv-contrib.outcome == 'success' }}
# run: ./bin/opencv_test_gapi --gtest_filter=${{ env.GTEST_FILTER_STRING }} --test_threads=$PARALLEL_JOBS
# working-directory: ${{ github.workspace }}/build
- name: Accuracy:gapi
timeout-minutes: 60
if: ${{ always() && steps.build-opencv-contrib.outcome == 'success' }}
run: ./bin/opencv_test_gapi --gtest_filter=${{ env.GTEST_FILTER_STRING }} --test_threads=$PARALLEL_JOBS
working-directory: ${{ github.workspace }}/build
- name: Accuracy:hdf
timeout-minutes: 60
if: ${{ always() && steps.build-opencv-contrib.outcome == 'success' }}
Expand Down Expand Up @@ -398,11 +398,11 @@ jobs:
if: ${{ always() && steps.build-opencv-contrib.outcome == 'success' }}
run: ./bin/opencv_perf_features2d --perf_impl=plain --perf_min_samples=1 --perf_force_samples=1 --perf_verify_sanity --skip_unstable=1 --gtest_filter=${{ env.GTEST_FILTER_STRING }} --perf_threads=$PARALLEL_JOBS
working-directory: ${{ github.workspace }}/build
# - name: Performance:gapi
# timeout-minutes: 60
# if: ${{ always() && steps.build-opencv-contrib.outcome == 'success' }}
# run: ./bin/opencv_perf_gapi --perf_impl=plain --perf_min_samples=1 --perf_force_samples=1 --perf_verify_sanity --skip_unstable=1 --gtest_filter=${{ env.GTEST_FILTER_STRING }} --perf_threads=$PARALLEL_JOBS
# working-directory: ${{ github.workspace }}/build
- name: Performance:gapi
timeout-minutes: 60
if: ${{ always() && steps.build-opencv-contrib.outcome == 'success' }}
run: ./bin/opencv_perf_gapi --perf_impl=plain --perf_min_samples=1 --perf_force_samples=1 --perf_verify_sanity --skip_unstable=1 --gtest_filter=${{ env.GTEST_FILTER_STRING }} --perf_threads=$PARALLEL_JOBS
working-directory: ${{ github.workspace }}/build
- name: Performance:imgcodecs
timeout-minutes: 60
if: ${{ always() && steps.build-opencv-contrib.outcome == 'success' }}
Expand Down
21 changes: 17 additions & 4 deletions .github/workflows/OCV-PR-4.x-ARM64.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -59,12 +59,17 @@ jobs:
- name: Fetch opencv
timeout-minutes: 60
run: git clone --branch ${{ env.TARGET_BRANCH_NAME }} --reference ${{ env.GIT_CACHE_DOCKER }}/opencv.git https://github.com/opencv/opencv.git ${{ env.OPENCV_DOCKER_WORKDIR }}
- name: Merge opencv with ${{ env.SOURCE_BRANCH_NAME }} branch
# - name: Merge opencv with ${{ env.SOURCE_BRANCH_NAME }} branch
# timeout-minutes: 60
# if: ${{ github.event.repository.name != 'ci-gha-workflow' }}
# run: |
# cd ${{ env.OPENCV_DOCKER_WORKDIR }}
# git pull -v "https://github.com/${{ env.PR_AUTHOR_FORK }}" "${{ env.SOURCE_BRANCH_NAME }}"
- name: Merge opencv with test branch
timeout-minutes: 60
if: ${{ github.event.repository.name != 'ci-gha-workflow' }}
run: |
cd ${{ env.OPENCV_DOCKER_WORKDIR }}
git pull -v "https://github.com/${{ env.PR_AUTHOR_FORK }}" "${{ env.SOURCE_BRANCH_NAME }}"
cd ${{ env.OPENCV_DOCKER_WORKDIR }}
git pull -v "https://github.com/anna-khakimova/opencv" "ak/fix_resize4lpi_tests"
- name: Clone opencv_extra
timeout-minutes: 60
run: git clone --single-branch --branch ${{ env.TARGET_BRANCH_NAME }} --reference ${{ env.GIT_CACHE_DOCKER }}/opencv_extra.git https://github.com/opencv/opencv_extra.git $HOME/opencv_extra
Expand Down Expand Up @@ -130,6 +135,10 @@ jobs:
timeout-minutes: 60
if: ${{ always() && steps.build-opencv.outcome == 'success' }}
run: cd $HOME/build && xvfb-run -a bin/opencv_test_flann --test_threads=${{ env.PARALLEL_JOBS }}
- name: Accuracy:gapi
timeout-minutes: 60
if: ${{ always() && steps.build-opencv.outcome == 'success' }}
run: cd $HOME/build && xvfb-run -a bin/opencv_test_gapi --test_threads=${{ env.PARALLEL_JOBS }}
- name: Accuracy:highgui
timeout-minutes: 60
if: ${{ always() && steps.build-opencv.outcome == 'success' }}
Expand Down Expand Up @@ -182,6 +191,10 @@ jobs:
timeout-minutes: 60
if: ${{ always() && steps.build-opencv.outcome == 'success' }}
run: cd $HOME/build && xvfb-run -a bin/opencv_perf_features2d --perf_impl=plain --perf_min_samples=1 --perf_force_samples=1 --perf_verify_sanity --skip_unstable=1 --perf_threads=${{ env.PARALLEL_JOBS }}
- name: Performance:gapi
timeout-minutes: 60
if: ${{ always() && steps.build-opencv.outcome == 'success' }}
run: cd $HOME/build && xvfb-run -a bin/opencv_perf_gapi --perf_impl=plain --perf_min_samples=1 --perf_force_samples=1 --perf_verify_sanity --skip_unstable=1 --perf_threads=${{ env.PARALLEL_JOBS }}
- name: Performance:imgcodecs
timeout-minutes: 60
if: ${{ always() && steps.build-opencv.outcome == 'success' }}
Expand Down
31 changes: 18 additions & 13 deletions .github/workflows/OCV-PR-4.x-macOS-ARM64.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -127,11 +127,11 @@ jobs:
if: ${{ always() && steps.build-opencv.outcome == 'success' }}
run: ./bin/opencv_test_flann --gtest_filter=${{ env.GTEST_FILTER_STRING }} --test_threads=$PARALLEL_JOBS
working-directory: ${{ github.workspace }}/build
# - name: Accuracy:gapi
# timeout-minutes: 60
# if: ${{ always() && steps.build-opencv.outcome == 'success' }}
# run: ./bin/opencv_test_gapi --gtest_filter=${{ env.GTEST_FILTER_STRING }} --test_threads=$PARALLEL_JOBS
# working-directory: ${{ github.workspace }}/build
- name: Accuracy:gapi
timeout-minutes: 60
if: ${{ always() && steps.build-opencv.outcome == 'success' }}
run: ./bin/opencv_test_gapi --gtest_filter=${{ env.GTEST_FILTER_STRING }} --test_threads=$PARALLEL_JOBS
working-directory: ${{ github.workspace }}/build
- name: Accuracy:highgui
timeout-minutes: 60
if: ${{ always() && steps.build-opencv.outcome == 'success' }}
Expand Down Expand Up @@ -197,11 +197,11 @@ jobs:
if: ${{ always() && steps.build-opencv.outcome == 'success' }}
run: ./bin/opencv_perf_features2d --perf_impl=plain --perf_min_samples=1 --perf_force_samples=1 --perf_verify_sanity --skip_unstable=1 --gtest_filter=${{ env.GTEST_FILTER_STRING }} --perf_threads=$PARALLEL_JOBS
working-directory: ${{ github.workspace }}/build
# - name: Performance:gapi
# timeout-minutes: 60
# if: ${{ always() && steps.build-opencv.outcome == 'success' }}
# run: ./bin/opencv_perf_gapi --perf_impl=plain --perf_min_samples=1 --perf_force_samples=1 --perf_verify_sanity --skip_unstable=1 --gtest_filter=${{ env.GTEST_FILTER_STRING }} --perf_threads=$PARALLEL_JOBS
# working-directory: ${{ github.workspace }}/build
- name: Performance:gapi
timeout-minutes: 60
if: ${{ always() && steps.build-opencv.outcome == 'success' }}
run: ./bin/opencv_perf_gapi --perf_impl=plain --perf_min_samples=1 --perf_force_samples=1 --perf_verify_sanity --skip_unstable=1 --gtest_filter=${{ env.GTEST_FILTER_STRING }} --perf_threads=$PARALLEL_JOBS
working-directory: ${{ github.workspace }}/build
- name: Performance:imgcodecs
timeout-minutes: 60
if: ${{ always() && steps.build-opencv.outcome == 'success' }}
Expand Down Expand Up @@ -285,10 +285,15 @@ jobs:
timeout-minutes: 60
run: git clone --branch ${{ env.TARGET_BRANCH_NAME }} --reference $GIT_CACHE/opencv.git https://github.com/opencv/opencv.git
working-directory: ${{ github.workspace }}
- name: Merge opencv with a test branch
# - name: Merge opencv with a test branch
# timeout-minutes: 60
# if: ${{ github.event.repository.name != 'ci-gha-workflow' }}
# run: git pull -v "https://github.com/${{ env.PR_AUTHOR_FORK }}" "${{ env.SOURCE_BRANCH_NAME }}"
# working-directory: ${{ github.workspace }}/opencv
- name: Merge opencv with test branch
timeout-minutes: 60
if: ${{ github.event.repository.name != 'ci-gha-workflow' }}
run: git pull -v "https://github.com/${{ env.PR_AUTHOR_FORK }}" "${{ env.SOURCE_BRANCH_NAME }}"
run: |
git pull -v "https://github.com/anna-khakimova/opencv" "ak/fix_resize4lpi_tests"
working-directory: ${{ github.workspace }}/opencv
- name: Clone opencv_contrib
timeout-minutes: 60
Expand Down
8 changes: 8 additions & 0 deletions .github/workflows/OCV-PR-5.x-ARM64.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -134,6 +134,10 @@ jobs:
timeout-minutes: 60
if: ${{ always() && steps.build-opencv.outcome == 'success' }}
run: cd $HOME/build && xvfb-run -a bin/opencv_test_flann --test_threads=${{ env.PARALLEL_JOBS }}
- name: Accuracy:gapi
timeout-minutes: 60
if: ${{ always() && steps.build-opencv.outcome == 'success' }}
run: cd $HOME/build && xvfb-run -a bin/opencv_test_gapi --test_threads=${{ env.PARALLEL_JOBS }}
- name: Accuracy:highgui
timeout-minutes: 60
if: ${{ always() && steps.build-opencv.outcome == 'success' }}
Expand Down Expand Up @@ -194,6 +198,10 @@ jobs:
timeout-minutes: 60
if: ${{ always() && steps.build-opencv.outcome == 'success' }}
run: cd $HOME/build && xvfb-run -a bin/opencv_perf_features2d --perf_impl=plain --perf_min_samples=1 --perf_force_samples=1 --perf_verify_sanity --skip_unstable=1 --perf_threads=${{ env.PARALLEL_JOBS }}
- name: Performance:gapi
timeout-minutes: 60
if: ${{ always() && steps.build-opencv.outcome == 'success' }}
run: cd $HOME/build && xvfb-run -a bin/opencv_perf_gapi --perf_impl=plain --perf_min_samples=1 --perf_force_samples=1 --perf_verify_sanity --skip_unstable=1 --perf_threads=${{ env.PARALLEL_JOBS }}
- name: Performance:imgcodecs
timeout-minutes: 60
if: ${{ always() && steps.build-opencv.outcome == 'success' }}
Expand Down
Loading