Pin deps to fix tests, ditch docker for uv in GHA #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was only used to test the blocksize of the overviews of COGs being created, since they had used 128 as a default. However, since gdal 3.1 the default has changed to be the same as the blocksize as the main image. This should mean this is no longer and issue, and we no longer need to install gdal just to run one test.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #374 +/- ##
===========================================
+ Coverage 84.44% 84.74% +0.30%
===========================================
Files 26 26
Lines 4506 4530 +24
===========================================
+ Hits 3805 3839 +34
+ Misses 701 691 -10 ☔ View full report in Codecov by Sentry. |
|
@omad Not sure if it's useful, but re parallelization, we currently run our https://github.com/GeoscienceAustralia/eo-tides/blob/main/.github%2Fworkflows%2Fmain.yml#L40-L47 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've broken my own rule and combined a few changes in the one PR, sorry!!
gdalas a test dependency. According to the gdal docs, what we were testing for has been remedied since version 3.1 which came out 4 years ago. Overview block size now defaults to the same size as the main images instead of 128.gdalfrom testing, I can also ditchdockerin GHA, which massively simplifies the test setup. And it's faster. Saves about 1m in GHA.pytest-xdist, which required removing a usage ofsys.argvfrom one of the data prep scripts, which was only there to give a warning about outdated usage from years ago. Test execution in GHA drops from about 4m to 2.5m.