Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TrustyAI] Add tests for fairness metrics and refactor TrustyAIService #131

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

adolfo-ab
Copy link
Contributor

This PR adds tests for the TrustyAIService fairness metrics, and refactors the main code that interacts with TrustyAIService

Description

Refactors the TrustyAIService utils to make them more generic
Refactors Trusty functions to send inferences, in order to use run_inference_flow
Improve function to check if TrustyAIService registers isvc
Adds new tests for fairness metrics
Migrates drift tests from modelmesh to kserve
Moves create_isvc to utilities/infra.py
Removes utilities/general.py content to infra.py to avoid circular imports

How Has This Been Tested?

Running the code against a working cluster

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link

github-actions bot commented Feb 7, 2025

The following are automatically added/executed:

Available user actions:

  • To mark a PR as WIP, add /wip in a comment. To remove it from the PR comment /wip cancel to the PR.
  • To block merging of a PR, add /hold in a comment. To un-block merging of PR comment /hold cancel.
  • To mark a PR as approved, add /lgtm in a comment. To remove, add /lgtm cancel.
    lgtm label removed on each new commit push.
  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
Supported labels

{'/wip', '/lgtm', '/hold', '/verified'}

@adolfo-ab adolfo-ab marked this pull request as ready for review February 7, 2025 16:38
@adolfo-ab
Copy link
Contributor Author

/verified

@github-actions github-actions bot added the Verified Verified pr in Jenkins label Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/xxl Verified Verified pr in Jenkins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant