This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Add missing upstream rca node for heap health decider #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yojs
approved these changes
Oct 16, 2020
vigyasharma
reviewed
Oct 16, 2020
| @@ -200,7 +199,7 @@ public void construct() { | |||
| HeapHealthDecider heapHealthDecider = new HeapHealthDecider(RCA_PERIOD, highHeapUsageClusterRca, | |||
| largeHeapClusterRca); | |||
| heapHealthDecider.addTag(TAG_LOCUS, LOCUS_MASTER_NODE); | |||
| heapHealthDecider.addAllUpstreams(Collections.singletonList(highHeapUsageClusterRca)); | |||
| heapHealthDecider.addAllUpstreams(Arrays.asList(highHeapUsageClusterRca, largeHeapClusterRca)); | |||
There was a problem hiding this comment.
Did we add decider integ tests? How did they pass without this?
There was a problem hiding this comment.
No, we don't have decider integ tests yet.
How did they pass without this?
Not having it in the upstream list won't necessarily fail the integration test even if we had one. The scheduler can at worst get the scheduling wrong and have the decider run before the RCA(because they'll be executed in parallel based on the distance from the leaf nodes). This causes race conditions which may or may not fail in the integ test. This upstream dependency was present in the 128G PR: #439 though, so this wouldn't have been caught then. Maybe at/after merge?
sidheart
approved these changes
Oct 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #:
#476
Description of changes:
Adds LargeHeapClusterRca - the cluster level RCA for detecting heap size increase opportunities - as an upstream to the HeapHealthDecider.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.