This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 186
Adding additional logging to ExprMissingValue exception #973
Open
FreCap
wants to merge
5
commits into
opendistro-for-elasticsearch:develop
Choose a base branch
from
FreCap:develop
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #973 +/- ##
=============================================
- Coverage 99.89% 99.87% -0.03%
+ Complexity 2412 2350 -62
=============================================
Files 236 232 -4
Lines 5503 5413 -90
Branches 329 349 +20
=============================================
- Hits 5497 5406 -91
Misses 5 5
- Partials 1 2 +1
Continue to review full report at Codecov.
|
penghuo
reviewed
Jan 7, 2021
...java/com/amazon/opendistroforelasticsearch/sql/legacy/expression/model/ExprMissingValue.java
Show resolved
Hide resolved
@FreCap any update from your side, thanks |
chloe-zh
approved these changes
Feb 5, 2021
Field comparison legacy
Default files in lf format
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
In a simple GROUP BY queries I'm getting the following exception and need more info about the problem:
FAILS
WORKS with ?format=json
Description of changes:
Adding additional details to the error message
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.