-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Volume Health Information #946
Open
tiagolobocastro
wants to merge
10
commits into
develop
Choose a base branch
from
pstor-watcher
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+766
−88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tiagolobocastro
commented
Mar 11, 2025
Signed-off-by: Tiago Castro <[email protected]>
When a volume is deleted, destroy all related health entries. It has been observed that upon republished, the previous info is not deleted, so even if we fix that a lot of entries may already be leaked, so let's ensure we delete all entries for a given volume on volume deletion. Signed-off-by: Tiago Castro <[email protected]>
Add a volume health watcher which caches updates from etcd for every volume. When etcd entry is deleted, the equivalent entry in the cache is also deleted. When volume is republished sucessfully, the older target health information are also removed from the cache. Signed-off-by: Tiago Castro <[email protected]>
Enhance the volume with pstor health information which is retried from etcd using watches. Signed-off-by: Tiago Castro <[email protected]>
Signed-off-by: Tiago Castro <[email protected]>
Signed-off-by: Tiago Castro <[email protected]>
If the target is meant to be there, but it's missing, state that. Signed-off-by: Tiago Castro <[email protected]>
a17fd08
to
b4bd7ff
Compare
Abhinandan-Purkait
approved these changes
Mar 14, 2025
Checks the volume health as replicas are faulted, rebuilt and targets shutdown cleanly or otherwise. Signed-off-by: Tiago Castro <[email protected]>
Signed-off-by: Tiago Castro <[email protected]>
b4bd7ff
to
42c9989
Compare
advisory: GHSA-4p46-pwfr-66x6 Signed-off-by: Tiago Castro <[email protected]>
Abhinandan-Purkait
approved these changes
Mar 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.