Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rest-plugin): delete volume by uuid #947

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

tiagolobocastro
Copy link
Contributor

Add delete volume subcommand to the rest-plugin utility. The K8s plugin utility will add additional checks, such as ensuring the equivalent PV is already deleted.

Add delete volume subcommand to the rest-plugin utility.
The K8s plugin utility will add additional checks, such as
ensuring the equivalent PV is already deleted.

Signed-off-by: Tiago Castro <[email protected]>
@tiagolobocastro tiagolobocastro requested a review from a team as a code owner March 15, 2025 00:35
@tiagolobocastro
Copy link
Contributor Author

First step of openebs/mayastor#1835

@Abhinandan-Purkait
Copy link
Member

Shouldn't the csi controller garbage collector extend this feature rather than a manual cli command, looks risky to me, how do you ensure we don't end up deleting a wrong volume. Maybe add a double confirmation?

@tiagolobocastro
Copy link
Contributor Author

Shouldn't the csi controller garbage collector extend this feature rather than a manual cli command, looks risky to me, how do you ensure we don't end up deleting a wrong volume. Maybe add a double confirmation?

What do you mean by "extend this feature"? The whole point is that it's not safe to garbage collect these volumes, it should be a manual procedure.
The kubectl plugin will double check and ensure that the deletion volume does not have an equivalent PV.

By double confirmation, you mean like: "type Y or YES" to confirm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants