fix: serialization of unfinished, unscored peer assignments (#2142)

* fix: fix serializing of null assessments in score

* chore: bump ORA to 6.0.16

openassessment/__init__.py

@@ -2,4 +2,4 @@
 Initialization Information for Open Assessment Module
 """
 
-__version__ = '6.0.15'
+__version__ = '6.0.16'

openassessment/assessment/models/peer.py

@@ -528,7 +528,7 @@ def _get_assessments(cls, submission_uuid, scored):
         return Assessment.objects.filter(
             pk__in=[
                 item.assessment.pk for item in PeerWorkflowItem.objects.filter(
-                    submission_uuid=submission_uuid, scored=scored
+                    submission_uuid=submission_uuid, scored=scored, assessment__isnull=False
                 )
             ]
         )

openassessment/assessment/test/test_peer.py

@@ -1243,6 +1243,19 @@ def test_get_assessment_feedback_error(self, mock_filter):
             tim_answer, __ = self._create_student_and_submission("Tim", "Tim's answer", MONDAY)
             peer_api.get_assessment_feedback(tim_answer['uuid'])
 
+    def test_get_assessments_null(self):
+        # Test to fix serialization of incomplete, unscored assessments
+
+        # Tim & Buffy submit
+        tim_answer, _ = self._create_student_and_submission("Tim", "Tim's answer")
+        buffy_answer, _ = self._create_student_and_submission("Buffy", "Buffy's answer")
+
+        # Buffy starts but does not finish assessing Tim's answer
+        peer_api.get_submission_to_assess(buffy_answer['uuid'], REQUIRED_GRADED_BY)
+
+        # Tim gets unscored assessments, this used to throw an error
+        PeerWorkflowItem.get_unscored_assessments(tim_answer["uuid"])
+
     @patch('openassessment.assessment.models.peer.PeerWorkflowItem.get_scored_assessments')
     def test_set_assessment_feedback_error(self, mock_filter):
         with raises(peer_api.PeerAssessmentInternalError):

package.json

@@ -1,6 +1,6 @@
 {
   "name": "edx-ora2",
-  "version": "6.0.15",
+  "version": "6.0.16",
   "repository": "https://github.com/openedx/edx-ora2.git",
   "dependencies": {
     "@edx/frontend-build": "8.0.6",