Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat: call python methods from forum v2 #35490

Commits on Sep 16, 2024

  1. feat: call python methods from forum v2

    - directly call python native APIs from forum v2 for pin, unpin thread,
    commentables count_stats and get user's data by user_id
    - add forum to the edx-platform requirements
    Muhammad Faraz Maqsood authored and Muhammad Faraz Maqsood committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    9126017 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. feat: migrate some APIs to native python

    - directly call python native APIs from forum v2 for get parent comment,
    create parent comment and create child comment.
    - rename retrieve_commentables_stats method to get_commentables_stats and
    retrieve_user to get_user.
    Muhammad Faraz Maqsood authored and Muhammad Faraz Maqsood committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    5ff3c66 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. feat: pass params to python native APIs

    - refactored code and now pass proper parameters to python native APIs
    instead of a single dict
    Muhammad Faraz Maqsood authored and Muhammad Faraz Maqsood committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    896f9a1 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. feat: code refactor and migrate delete comment API

    Muhammad Faraz Maqsood authored and Muhammad Faraz Maqsood committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    3a7b24b View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. fix: user tests

    Ali-Salman29 committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    bf87423 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. feat: fix tests for get_user API

    - get_user API tests are now passing in test_views.py and test_serializers.py
    - add get_user api patch in all tests
    - fix httppretty request count in some tests
    - fix test_patch_read_non_owner_user test
    Muhammad Faraz Maqsood committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    b382053 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. feat: use new coursewaffle flag to run old code

    - add `ENABLE_FORUM_V2` course waffle flag to switch between old code i.e.
    cs_comment_service and new code i.e. forum v2.
    - mock course waffle flag is_enabled method i.e. ENABLE_FORUM_V2.is_enabled(),
    so that old unit tests can be run and passed.
    - refactor code(that parts of code whose native APIs are implemented till now)
    where we call the native APIs
    Muhammad Faraz Maqsood committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    284e7da View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cb58346 View commit details
    Browse the repository at this point in the history
  3. fix: resolve inconsistant python dependencies

    - run `make compile-requirements forum`. Error: It appears that the
    Python dependencies in this PR are inconsistent: A re-run of
    `make compile-requirements` produced changes.
    - fix quality checks
    Muhammad Faraz Maqsood committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    740b127 View commit details
    Browse the repository at this point in the history
  4. fix: fix new failing tests

    - fix new tests related to discussion that failed after fixing previous tests
    these are failing due to no.of argument difference
    https://github.com/openedx/edx-platform/actions/runs/11069160532/job/30756121710?pr=35490
    Muhammad Faraz Maqsood committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    8cdc9fc View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. feat: migrate user active_thread api

    Muhammad Faraz Maqsood committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    1447495 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    634af22 View commit details
    Browse the repository at this point in the history
  3. feat: add python native APIs from forum v2

    - migrate following native APIs i.e. mark_thread_as_read, create_subscription,
    delete_subscription, update_thread_votes, update_comment_votes, delete_thread_vote,
    delete_comment_vote, get_user_threads, retire_user, update_username,
    get_user_course_stats, update_users_in_course, flag/unflag comment/threads
    from forum v2 to edx-platform
    - refactor some code
    Muhammad Faraz Maqsood committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    e224041 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    da19a4c View commit details
    Browse the repository at this point in the history
  5. feat: add threads api

    Muhammad Faraz Maqsood authored and Muhammad Faraz Maqsood committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    d5fadc5 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. fix: quality checks

    Muhammad Faraz Maqsood authored and Muhammad Faraz Maqsood committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    d7d8228 View commit details
    Browse the repository at this point in the history
  2. feat: migrate update_user api

    Muhammad Faraz Maqsood authored and Muhammad Faraz Maqsood committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    e3d16c8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5482991 View commit details
    Browse the repository at this point in the history
  4. fix: course_id issue for course_waffle flag

    Muhammad Faraz Maqsood committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    efc1d60 View commit details
    Browse the repository at this point in the history
  5. fix: temp

    Ali-Salman29 committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    f93e079 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2024

  1. chore: code refactor, fix quality checks

    Muhammad Faraz Maqsood committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    0d398a8 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. feat: add tests for native APIs

    in this commit:
    - migrated the tests for native APIs from test_serializers to test_serializers_native_views file.
    - tests from test_views to test_views_native_views is still in progress
    - fixed edx-platform tests which were failing after we added get course_id APIs
    - fixed course_key error for user's retrieve APIs
    Muhammad Faraz Maqsood committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    a7053b9 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. Configuration menu
    Copy the full SHA
    7457944 View commit details
    Browse the repository at this point in the history
  2. feat: new native APIs tests progress

    Muhammad Faraz Maqsood committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    5f135e4 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    40fdb15 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b061b26 View commit details
    Browse the repository at this point in the history
  5. chore: move native API tests to separate PR

    Muhammad Faraz Maqsood committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    787d16c View commit details
    Browse the repository at this point in the history
  6. fix: CI checks

    Muhammad Faraz Maqsood committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    922dfe6 View commit details
    Browse the repository at this point in the history
  7. chore: change the forum branch to master

    Muhammad Faraz Maqsood committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    a85d0e6 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. fix: older edx-platform tests that uses V1

    - Before resolving course_id availability issue for all APIs to be used in
    CourseWaffle flag, only 4 files tests were failing, We fixed those.
    Now due to latest fixes, some more tests were failing that uses v1, this PR will
    fix those issues.
    Muhammad Faraz Maqsood committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    2586a8d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5ef8196 View commit details
    Browse the repository at this point in the history
  3. feat: pass course_id to native APIs

    course_id is needed to be used in second coursewaffle flag
    Muhammad Faraz Maqsood committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    5aa42da View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. Configuration menu
    Copy the full SHA
    c2111ef View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3162554 View commit details
    Browse the repository at this point in the history
  3. fix: pylint issues

    Muhammad Faraz Maqsood committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    af8e057 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e956b63 View commit details
    Browse the repository at this point in the history
  5. fix: tests, add mocks for getting course_id APIs

    Muhammad Faraz Maqsood committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    4b26ebc View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    cc68bd7 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2024

  1. fix: failing unit tests

    Muhammad Faraz Maqsood committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    4bcf51b View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. refactor: remove unnecessary try catch

    Muhammad Faraz Maqsood committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    40ff7f1 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. Configuration menu
    Copy the full SHA
    8dd878d View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. Configuration menu
    Copy the full SHA
    24a00ff View commit details
    Browse the repository at this point in the history